fix(sidebar): respect render prop when tooltip is present (Base UI) #9294
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shadcn-ui#9277 Changed SidebarMenuButton to always use the render prop and wrap it with TooltipTrigger using composition. This preserves the composition chain: TooltipTrigger → Link → button content. Before: When tooltip was present, render prop was replaced with TooltipTrigger After: render prop is always respected, then wrapped with TooltipTrigger
Contributor
|
@0372hoanghoccode is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9277
Changed SidebarMenuButton to always use the render prop and wrap it with TooltipTrigger using composition. This preserves the composition chain: TooltipTrigger → Link → button content.
Changes
ender prop instead of conditionally replacing it with TooltipTrigger`n- Changed line 548: Wrap comp with when tooltip is present
Before
When tooltip was present, the render prop was replaced with TooltipTrigger, losing any custom render component (like Link).
After
The render prop is always respected, then wrapped with TooltipTrigger using composition, preserving the full component chain.
Type of change