Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github release build failure #5183

Closed
csyonghe opened this issue Sep 28, 2024 · 12 comments
Closed

Fix github release build failure #5183

csyonghe opened this issue Sep 28, 2024 · 12 comments
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang

Comments

@csyonghe
Copy link
Collaborator

csyonghe commented Sep 28, 2024

Need to fix the rhi/dawn issue:

/usr/lib/gcc-cross/aarch64-linux-gnu/9/../../../../aarch64-linux-gnu/bin/ld: _deps/dawn-src/lib64/libdawn.so: error adding symbols: file in wrong format

We should consider just build libdawn.so for aarch64.

Please note that this issue needs to be fixed as P0 since it is blocking us from creating a release.

@csyonghe csyonghe added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Sep 28, 2024
@csyonghe csyonghe assigned expipiplus1 and aleino-nv and unassigned expipiplus1 Sep 28, 2024
@aleino-nv
Copy link
Collaborator

Why don't we just disable WebGPU for non-Windows platforms, for the time being? I thought that was the original plan?

@aleino-nv
Copy link
Collaborator

Also, I had the impression that @skallweitNV was working on this. (?)

@aleino-nv
Copy link
Collaborator

@skallweitNV Tells me the plan is to disable WebGPU backend on Linux, for now.

@westlicht
Copy link
Contributor

Yes, that's the immediate fix in #5186. However, the correct fix will be to use a proper cmake toolchain file to cross-compile slang for linux/aarch64. This will correctly set the CMAKE_SYSTEM_PROCESSOR variable that slang-rhi depends on to select the correct dawn library. I have already setup the full build matrix for dawn binaries. So once the slang side is fixed, we can enable all builds again.

@aleino-nv
Copy link
Collaborator

Given

We should consider just build libdawn.so for aarch64.

and

I have already setup the full build matrix for dawn binaries

I'll assign this to @skallweitNV, then.

@csyonghe
Copy link
Collaborator Author

Slang's current cmake support already include Linux aarch64 builds.

@bmillsNV
Copy link
Collaborator

bmillsNV commented Oct 1, 2024

@skallweitNV what's left for this one? Do we still have a build failure?

@skallweitNV
Copy link
Collaborator

The release build works. For now WebGPU is disabled for Linux builds. In slang-rhi everything is done to support Linux for both x86_64 and aarch64 platforms. To get it all working the slang project needs to setup proper cmake cross-compilation for linux/aarch64 using a cmake toolchain file. Then we can re-enable WebGPU for Linux by removing this block: https://github.com/shader-slang/slang/blob/master/external/CMakeLists.txt#L74

@bmillsNV bmillsNV assigned aleino-nv and unassigned skallweitNV Oct 2, 2024
@bmillsNV
Copy link
Collaborator

bmillsNV commented Oct 2, 2024

@aleino-nv could you add the the cmake item to your list?

@aleino-nv
Copy link
Collaborator

aleino-nv commented Oct 2, 2024

@bmillsNV This stuff is usually a bit of a time sink, at least for me -- is this really a priority?

That is to say, do we really need to support running our own Slang/WGSL test apps natively on mobile devices right now? At least this should have no impact on the demo we're working on.

@csyonghe
Copy link
Collaborator Author

csyonghe commented Oct 2, 2024

@westlicht we use native asrch64 machine in the ci to create a slang release for Linux aarch64. Doesn't slang-rhi support native aarch64 build?

@csyonghe
Copy link
Collaborator Author

csyonghe commented Nov 6, 2024

Closing as done.

@csyonghe csyonghe closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Development

No branches or pull requests

6 participants