Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F #he 948 improve calibration process #56

Open
wants to merge 25 commits into
base: noetic-devel
Choose a base branch
from

Commits on Jun 13, 2023

  1. fix progress bar logic

    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    611aa77 View commit details
    Browse the repository at this point in the history
  2. tf subscriber takes time to start up. Added a small sleep to make sur…

    …e we actually have data points when we first call fit_sphere(...) which prevents three numpy RuntimeWarnings (we were sometimes calling np.std on an empty list)
    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7018f5b View commit details
    Browse the repository at this point in the history
  3. add 'divisor' to tf callback, lets us only save every 'x' tf messages…

    …. Speeds up computation but potentially reduces accuracy. Needs testing
    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    aa51421 View commit details
    Browse the repository at this point in the history
  4. save results from previous sphere_fit and use as the initial guess fo…

    …r the next sphere_fit. Speeds up computation time
    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a6da349 View commit details
    Browse the repository at this point in the history
  5. lint

    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    dec9b13 View commit details
    Browse the repository at this point in the history
  6. tidying

    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    814c95c View commit details
    Browse the repository at this point in the history
  7. removed unused import

    carebare47 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e024ce5 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    5ed88bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17d5fd4 View commit details
    Browse the repository at this point in the history
  3. fix initial guess storage (was per hand, now per finger, now signific…

    …antly faster), and fix parameter from launch file
    carebare47 committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    717d929 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b99a89 View commit details
    Browse the repository at this point in the history
  5. turns out '_load_tf_callback' was missing ~80% of messages due to it'…

    …s execution time being too long (the number of msgs recieved was system-dependant and made it impossible to compare accuracy of calibration fits between runs). Modified code to save all tf messsages and process them in get_knuckle_positions. Added code to load a bag file for testing/tuning/comparing accuracy of calibration fits. Now that _load_tf_callback is recieving all the messages, the average number of msgs per second has gone up from ~15 to ~100, drastically increasing the computation of sphere fit. But, now we can add code to downsample to a KNOWN number of 'datapoints per second', giving the same performance across systems and lettings us actually figure out how many datapoints per second we need for a reasonable calibration fit
    carebare47 committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    47c845d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. now saves all tf messages and processes outside the callback, downsam…

    …pling to approximately a 'known' number of samples-per-second. Switched to MarkerArrays for faster marker publishing. Also general tidying
    carebare47 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2a8e44e View commit details
    Browse the repository at this point in the history
  2. make sure is valid for large values of

    carebare47 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c8cb706 View commit details
    Browse the repository at this point in the history
  3. add comment to explain

    carebare47 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    fefb9b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. now set timer rate to desired_num_datapoints_per_sec for testing mode…

    … with a bag
    carebare47 committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5955143 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. update default num datapoints per sec to 60

    carebare47 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    6992110 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    daf4b72 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'F_#HE_948_improve_calibration_process' of github.com:sh…

    …adow-robot/polhemus_ros_driver into F_#HE_948_improve_calibration_process
    carebare47 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c39a539 View commit details
    Browse the repository at this point in the history
  4. oops

    carebare47 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    368f107 View commit details
    Browse the repository at this point in the history
  5. lint

    carebare47 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c575a51 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    4dad4ee View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    c82377f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. fixing cal score calc

    carebare47 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    385df1a View commit details
    Browse the repository at this point in the history
  2. lint

    carebare47 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    60b5fcf View commit details
    Browse the repository at this point in the history