Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a SwitchControllerRequest object instead of python argument mapping #97

Open
wants to merge 1 commit into
base: melodic-devel
Choose a base branch
from

Conversation

guihomework
Copy link
Contributor

Proposed changes

Using a SwitchControllerRequest object instead of python argument mapping to a request object. This permits to be more "forward" compatible in case of future API changes that would break the current call if new parameters would be added (or changed place)

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we should look for before merging this code. I have:

  • Read and follow the contributing guidelines.
  • Checked that all tests pass with my changes
  • Added tests (automatic or manual) that prove the fix is effective or that the feature works
  • Added necessary documentation (if appropriate)
  • Added the corresponding license to each file and add the current year of any one that you modified.
  • Tested on real hardware (if appropriate)

@guihomework guihomework mentioned this pull request Feb 14, 2020
9 tasks
… request, to be compatible with future API changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant