Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to get rid of boost::detail::singleton #61

Open
v4hn opened this issue May 26, 2016 · 2 comments
Open

need to get rid of boost::detail::singleton #61

v4hn opened this issue May 26, 2016 · 2 comments

Comments

@v4hn
Copy link

v4hn commented May 26, 2016

At the moment, your code makes use of boost::detail::singleton in https://github.com/shadow-robot/sr_core/blob/indigo-devel/sr_utilities/include/sr_utilities/sr_math_utils.hpp#L33
I understand the reasoning behind this and I would leave it as it is, but ...
I found a bug in boost 1.60 related to your use-case and the author fixed the problem in boostorg/thread#83 .
However, he didn't even know of these files (which are 14 years old), they are (1.) not used by the project anymore, and (2.) are not part of the public API (that's what boost::detail is for).
So they'll probably go away with the next release even if the maintainer didn't remove them yet.

@guihomework
Copy link
Contributor

Is it possible that this issue does not occur anymore even without the fix of boost 1.60 thanks to this patch f330a04 removing the dependency to future.hpp

Of course when using the patched 1.60 future.hpp will also be fixed.

So the singleton usage could stay as long as it does not disappear from boost

@v4hn
Copy link
Author

v4hn commented Jan 5, 2017

Is it possible that this issue does not occur anymore even without the fix of boost 1.60 thanks to this patch f330a04 removing the dependency to future.hpp

Could be, I didn't test it recently.

Of course when using the patched 1.60 future.hpp will also be fixed.

My patch there got merged and is released in 1.63, so this bug shouldn't come back to haunt anyone.

So the singleton usage could stay as long as it does not disappear from boost

Well, yes and no. The singleton there is part of ::details - i.e. implementation details - but has not been used throughout the project in a long time. So it is quite likely that it will be removed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants