[ROS-O] support ImageMagick 6 and 7 (#31 for noetic) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getConstPixels changed from PixelPacket* to Quantum* in ImageMagick 7, so use Image::pixelColor instead. This is not as computationally efficient, but it generalizes between the versions. Co-authored-by: Beatriz Leon <beatriz@shadowrobot.com>
toliver
requested changes
Oct 3, 2022
as requested by Toni.
|
done |
v4hn
changed the title
|
Thank you. We need to sort out an issue with our AWS style_check (probably in the following weeks). We will merge this PR after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #31 to noetic.
Apparently noetic-devel was split off before #31 was merged, so the same issue comes up again.
This is required to compile sr_movements in RoboStack (e.g., on Ubuntu 22.04).
@biofotis