Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for restoring the deprecated AEAD cipher "XChaCha20-Poly1305-IETF" #2663

Closed
luminouser opened this issue Jan 18, 2021 · 6 comments
Closed

Request for restoring the deprecated AEAD cipher "XChaCha20-Poly1305-IETF" #2663

luminouser opened this issue Jan 18, 2021 · 6 comments
Labels
duplicate

Comments

@luminouser
Copy link

Please read contributing guidelines. Thanks.

Is your feature request related to a problem? Please describe.
It is thought that stream ciphers are unsafe for shadowsocks. However, XChaCha20-Poly1305-IETF is an AEAD construction, not just a stream cipher.
There is no clear evidence that AEAD constructions with stream ciphers are not safe. And stream ciphers are usually quicker than block ciphers. Furthermore, XChaCha20-Poly1305-IETF is the officially recommended cipher in libsodium documentation. read this

Describe the solution you'd like
Restoring the "XChaCha20-Poly1305-IETF" encryption scheme

Describe alternatives you've considered
None.

Additional context
None.
@gengen1988
Copy link

TLDR: It's impossible for now.

Long story:

In previous versions, this project using shadowsocks-libev to provide shadowsocks client implements. It relied on libsodium which has many experimental ciphers including XChaCha20-Poly1305-IETF. In mid 2020, shadowsocks-android switch to shadowsocks-rust as backend. It using crpyto2 as cipher implements. The crypto2 has no XChaCha20-Poly1305-IETF for some reason. That is why you can't use XChaCha20-Poly1305-IETF anymore.

If you wish to switch back old school libsodium, you may fork from v5.0.5

References:

shadowsocks/shadowsocks-rust#319 (Chinese)
https://github.com/shadowsocks/shadowsocks-libev
https://github.com/shadowsocks/shadowsocks-rust
https://github.com/shadowsocks/crypto2
https://github.com/jedisct1/libsodium

@IceCodeNew IceCodeNew mentioned this issue Feb 13, 2021
Closed
@Mygod
Copy link
Contributor

Mygod commented Apr 16, 2021

@zonyitoo @madeye Transfer this issue to shadowsocks-rust, or close?

@zonyitoo
Copy link

zonyitoo commented Apr 16, 2021 •
edited
Loading

It could be transferred to shadowsocks-rust.

A short version of why crypto2 won't support xchacha20-poly1305-ietf:

xchacha20-ietf-poly1305 is invented by libsodium and it is the only implementation in the whole world. They (libsodium) tried to make this algorithm become RFC standard. But as you can see, this RFC draft has already expired since January 24, 2020.

It is not about safe or unsafe. This algorithm is only a customized version of chacha20-ietf-poly1305 in libsodium. There is no strong reason about why we should support an algorithm that is not supported by any other libraries, and not accepted into RFC.

cc @LuoZijun

Further more, xchacha20-ietf-poly1305 is not defined in shadowsocks' AEAD ciphers: https://shadowsocks.org/en/wiki/AEAD-Ciphers.html .

@zonyitoo zonyitoo mentioned this issue Apr 16, 2021
Closed
zonyitoo added a commit to shadowsocks/shadowsocks-rust that referenced this issue Apr 17, 2021
@zonyitoo
update shadowsocks-crypto to v0.2.1
9d0c7cd 
- updated crypto2 to 0.1.2
- support AEAD extra ciphers with aead-cipher-extra
- fixes shadowsocks/shadowsocks-android#2663
- ref shadowsocks/shadowsocks-crypto#8
zonyitoo added a commit to shadowsocks/shadowsocks-rust that referenced this issue Apr 17, 2021
@zonyitoo
update shadowsocks-crypto to v0.2.1
04f420f 
- updated crypto2 to 0.1.2
- support AEAD extra ciphers with aead-cipher-extra
- fixes shadowsocks/shadowsocks-android#2663
- ref shadowsocks/shadowsocks-crypto#8
zonyitoo added a commit to shadowsocks/shadowsocks-rust that referenced this issue Apr 17, 2021
@zonyitoo
update shadowsocks-crypto to v0.2.1
40764b7 
- updated crypto2 to 0.1.2
- support AEAD extra ciphers with aead-cipher-extra
- fixes shadowsocks/shadowsocks-android#2663
- ref shadowsocks/shadowsocks-crypto#8
@zonyitoo
Copy link

zonyitoo commented Apr 17, 2021 •
edited
Loading

shadowsocks-rust v1.10.6 have included this non-standard cipher.

Consider enable it by adding --features "aead-cipher-extra".

@dev4u
Copy link
Contributor

dev4u commented Apr 17, 2021

shadowsocks-rust v1.10.6 have included this non-standard cipher.

Consider enable it by adding --features "aead-cipher-extra".

这个需要在安卓app端做相应修改才行的。

@gengen1988
Copy link

gengen1988 commented Apr 18, 2021 •
edited
Loading

I think "aead-cipher-extra" needs to be place here:

shadowsocks-android/core/build.gradle.kts

Lines 41 to 45 in 44dc47f

featureSpec.noDefaultBut(arrayOf(
"stream-cipher",
"logging",
"local-flow-stat",
"local-dns"))

Edit:

Ok, I realized this project need more change to remove "deprecated cipher" in UI

madeye added a commit that referenced this issue Apr 18, 2021
@madeye
Update shadowsocks-rust and add back some ciphers
181ef53 
Fix #2705 and #2663.
@Mygod Mygod closed this as completed Apr 18, 2021
JackyAnn added a commit to JackyAnn/shadowsocks-android that referenced this issue Sep 22, 2022
@JackyAnn @Mygod
@madeye @wyzdot @Goooler @SquallATF @dev4u
sync (#1)
b24c379 
* Allow user to keep data when uninstalling (shadowsocks#2506)

* Update README.md

* Update dependencies

* Add cargo clean task

* Enable LTO

* Speed up rebuild

* Update issue templates with labels

* Update dependencies

* Fix output name second attempt

* Update NDK

* Ensure cargoBuild is ran before mergeJniLibFolders

* Bump version

* Refine release build process

* Refine gradle files

* Add RUST_BACKTRACE

* Use rethrowAsSocketException

* Suppress write errors to protect_path

* Update shadowsocks-rust

* Bump version

* Improve accessibility

* Rename cipher plain to none

* Revert "Add RUST_BACKTRACE"

This reverts commit fdff88e.

ndk-stack should be used instead.

* Use cp.cloudflare.com for connectivity test

Credits: https://www.v2ex.com/t/656983#r_8748918

* Update dependencies

* Remote DNS setting is enabled unconditionally

* Show more information on conflicting plugins

Because one of you feckers just cannot learn to be decent.

* Add support for PTR queries

* Prevent querying PTR on custom Network

* Suppress network unspecified exceptions

* Handle IOException while reading

* Refine handling duplicate plugins

* Use any address as default DNS

* Suppress EACCES for ProtectWorker

* Clean up unused code

* Do not suppress IOException

* Disable UDP relay if plugin is enabled and no fallback

* Remove unnecessary isExperimental

* Update dependencies

* Fix unchecked cast

* Do not use WorkManager in device storage

* Remove unnecessary directBootAware overloading

* Suppress BadConfigurationProvider

* Disable RemoveWorkManagerInitializer lint for apps

* Update to Android 11 beta 1

* Request QUERY_ALL_PACKAGES for mobile

* Refine code style

* Fix ambiguous coroutineContext

* Downgrade coroutines

* Update dependencies

* Deprecate using Handler

* Fix shadowsocks#2546

* Only match exported plugins

* Update dependencies

* Update dependencies

* Migrate to ML kit for scanning QR code

Fixes shadowsocks#2548.

* Make scanner immersive

* Lock orientation to prevent camera recreation

* Fix missing Serializable declaration

* Add missing serialVersionUID

* Update dependencies

* Partially migrate to ActivityResultContracts

AlertDialogFragment will be migrated after the API goes stable.

* Add ActionBar to oss activity

* Add ActionBar to details activity

* Refine Scanner

* Bump version

* Update dependencies

* Suppress cancellation exceptions

* Skip processing if EOS is reached

* Refine PTR compat

* Fix shadowsocks#2557

* Fix shadowsocks#2562

* Update Android gradle

* Set VPN flag properly

Refine shadowsocks#2562.

* Drop support for Android Lollipop

* Update dependencies

* Remove UDP upstream DNS support. Fix shadowsocks#2564 shadowsocks#2518

* Update shadowsocks-rust

* Update dependencies

* Decouple main dependencies from plugin lib

* Simplify code

* Add missing type

* Update dependencies

* Deprecate old backup mechanism for Android 5-

* Update leanback theme to appcompat

* Use singleTask launchMode

* Fix build

* Bump version

* Update dependencies

* Update dependencies

* Bump plugin lib version to 2.0.0

* Add isV2 to PluginManager.InitResult

* Pass a value with the VPN option, if plugin version < 2.0

* Switch to __android_vpn

* Remove unnecessary parentheses

* Update shadowsocks-rust

* Bump version

* Clean up and bump version

* Revert camera-view back to alpha17

* Bump version

* Update dependencies

* Migrate away from deprecated APIs with core 1.3.0-alpha05

* Clean up code

* Refine code style

* Remove old ciphers. Fix shadowsocks#2621

* Enable single-threaded

* Update shadowsocks-rust to 1.8.23

* Use Parcelize for TrafficStats

* Fix platform insets on API 29-

* Fix shadowsocks#2623

* Update barcode-scanning

* Fix shadowsocks#2571

* Refine error message

* Refine shadowsocks#2571

* Limit open sockets to 256 in UDP association. Fix shadowsocks#2625

* Bump version

* Fix little problem of profile switching

* Update shadowsocks-rust to 1.9.0 (shadowsocks#2622)

* Fix shadowsocks#2638

* Bump version

* Switch to local UDP DNS resolver (shadowsocks#2635)

* Switch to the local UDP DNS resolver

* Update shadowsocks-rust

* Revert the rustup commands

* Fix shadowsocks#2642

* Fix the ByteBuffer allocation

* Update shadowsocks-rust

* Revert to local UDS resolver

Fix shadowsocks#2650

* Check deprecated ciphers (shadowsocks#2651)

* Bump version

* Fix shadowsocks#2301

* Bump version

* Remove the non-ietf chacha20 and salsa20 ciphers

* Fix shadowsocks#2665

* Update dependencies

* Fix deprecation of kotlin extensions

* Remove unused gcm work library for API 23+

* Use work-multiprocess

* Refine code style

* Update dependencies (shadowsocks#2672)

* Update dependencies

* Refine code style

* Bump gradle to 6.8.2

* Drop packet if out of buffer

* Refine error message

* Enlarge the buffer size of a UDP connection

* Bump version

* Ignore all exceptions whilst updating subscriptions

* Refine the JSON config file for ss-rust 1.10

* Refine the code style

* Update shadowsocks-rust to v1.10.3

* Fix shadowsocks#2679

* Update dependencies

Fixes shadowsocks#2699.

* Fix deprecation of adapterPosition

* Bump plugin to 2.0.1

* Migrate AlertDialogFragment to fragment result API

* Remove useless dependency update

* Migrate the rest to fragment result API

* Remove unused field

* Prevent crashing on shitty ROMs

* Add search tool for profiles (shadowsocks#2682)

* Suppress logging unsupported query type errors

* Ignore if connection was prematurely closed

* Use default udp_timeout=300 instead

Refine shadowsocks#2625.

* Mark underlyingNetwork as volatile

Attempts at addressing shadowsocks#2667.

* Fixed required targetFragments for preference

* Downgrade gradle plugin

* Update shadowsocks-rust and add back some ciphers

Fix shadowsocks#2705 and shadowsocks#2663.

* Update dependencies

* Check plugin properly

Fix shadowsocks#2667.

* Check crypto before init

* Make code style more Kotlin

* Update core and remove workaround

* Refine search to respect locale

* Double fixes touch target

* Resolve server name dynamically always (shadowsocks#2731)

Fixes shadowsocks#2722.

* Bump version

* Downgrade fragment to 1.3.2

Fixes shadowsocks#2733.

* Make plugin library depend on minimum version instead

* Enable Parallel GC

* Set useLegacyPackaging

* Update the maven publish plugin (shadowsocks#2734)

1. Remove the unnecessary custom URL
2. Replace jcenter with mavenCentral

* Handle illegal profiles properly

* Fix windows build failed shadowsocks#2666 shadowsocks#2711

* Allowed build under msys2 or cygwin

* Update dependencies

* Bring back semitransparent TV app via build variants (shadowsocks#2741)

This creates two variants for tv, freedom containing the original design, and google containing one matching Google's nonsense guideline. The former should be published on GitHub and elsewhere.

Revert "Revert "Revert "Revert "Revert "Make app fullscreen to match guidelines"""""

This reverts commit 0c67ac6.

* Fix typo

* Show full proxied apps mode to compensate for missing title

* Use MaterialAlertDialogBuilder

* Add progress indicator to ServiceButton

* Remove elevation from progress

* Only show progress for connecting

* Only show progress when connecting is taking too long

* Bump version

* Update dependencies

* Update sdk to S

* Use registerBestMatchingNetworkCallback

* Use OsConstants.ENONET

* Deal with new requirements

* Use main thread for default network callback on API 26+

* Remove unused code

* Fix duplicate authentication

* Update dependencies

* Bump version

* More stupid Android 6 bugs

* Update dependencies

* Downgrade leanback-preference

* Update to API 31

* Remove STORAGE permission on Android 10+

* Update dnsjava

* Ensure that redirects are always followed

Fixes shadowsocks#2786, shadowsocks#2791.

* Update dependencies

* Update to AGP 7.0.2

* Fix lint

* Update dependencies

* Fix shadowsocks#2803

* Remove extra file

* v5.2.6

* Revert "Show full proxied apps mode to compensate for missing title"

This reverts commit d21cf7b.

Fixes shadowsocks#2806.

* Add linkedin.com to gfwlist

* Fix Codacy badge

* Update dependencies

* Update .gitignore

ignore DS_Store

* Just to satisfy the obsessive-compulsive disorder :-)

* Update shadowsocks-rust

Update rust  dependency

* add new ciphers feature, and reorder cipher name

* Modify acl rules

* Update config.yml

try to fix up the rust build error

* enable armv8, neon feathures for hardware acceleration.

* Fix the missing springAnimator

* Update shadowsocks-rust to v1.15.0-alpha.5

* Bump version

* Update translations

Fixes shadowsocks#2867.

* Add German and Ukrainian translations

* Misc fixes

* Fix order

* Use system resolver

* Update dependencies

* Declare POST_NOTIFICATIONS

* Protect sensitive profile information when copied

* Add support for monochrome icons (not recommended)

* Declare supported languages

* Require authentication for closing service

* Support skipping animation in StatsBar

* Downgrade AGP

* Misc fixes

* Turn on fun switch

* Remove useless code

* Bump version

* Fix the compile error shadowsocks#2930 (shadowsocks#2935)

Make checking python version code compatible with windows and *nix

Redefine the python version detection code

Co-authored-by: Mygod <contact-github@mygod.be>
Co-authored-by: Mygod <contact-git@mygod.be>
Co-authored-by: Max Lv <max.c.lv@gmail.com>
Co-authored-by: cyber386 <62885475+cyber386@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
Co-authored-by: SquallATF <squallatf@gmail.com>
Co-authored-by: dev4u <dev4u@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@madeye @zonyitoo @dev4u @gengen1988 @Mygod @luminouser