服务端升级到shadowsocks-rust v1.15.0之后，客户端shadowsocks-android v5.3.1-preview不能使用

[qwerttvv]

ss用的是chacha20-ietf-poly1305，sip003是cloak，没敢裸连测试。其他不变，之前服务端版本v1.14.3没有使用问题。

另外目前服务端v1.15.0，客户端shadowsocks-rust v1.15.0-alpha.9，其它不变，使用是正常的

[madeye]

It should be a bug in the latest shadowsocks-rust. I saw a segfault of ss-rust on the server after enabling plugin. @zonyitoo

[zonyitoo]

That was strange. How can I reproduce? Could you provide more detail about sslocal? @qwerttvv

I saw a segfault of ss-rust on the server after enabling plugin.

Hmm, please provide more detail about ssserver, too.

v1.15.0 is nearly identical to v1.15.0-alpha.9.

[zonyitoo]

https://github.com/shadowsocks/shadowsocks-rust/actions/runs/3717954160/jobs/6305787076

It probably related to some bugs introduced from the latest nightly Rust. Please change toolchain to stable Rust. shadowsocks-rust is able to be compiled with stable Rust since 1.64.

[zonyitoo]

@dev4u Please remove features armv8 neon and use stable Rust toolchain.

[qwerttvv]

客户端v1.15.0-alpha.9配合服务端v1.14.3或v1.15.0都是可用的…原因未知，我只是编译路由器固件时用了新版客户端……

服务端升级到v1.15.1之后，客户端shadowsocks-android v5.3.1-preview可以使用了

[zonyitoo]

Good. shadowsocks-android should also upgrade the build script. ping @dev4u

[Mygod]

It probably related to some bugs introduced from the latest nightly Rust. Please change toolchain to stable Rust. shadowsocks-rust is able to be compiled with stable Rust since 1.64.

It's about time. 👍

[dev4u]

Good. shadowsocks-android should also upgrade the build script. ping @dev4u

@zonyitoo 不好意思，前几天身体不舒服。我整理一下PR上去。

[Mygod]

@zonyitoo So armv8 neon is removed for now? Do you have a link to the rust stabilization timeline of these features? Not sure why they need to take such a long time to stabilize such a trivial feature.

[zonyitoo]

Tracking Issue: rust-lang/stdarch#1266

Release Note: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1590-2022-02-24

[Mygod]

So they would be enabled already? And there had been no reason to build shadowsocks-rust on nightly since this February?

[zonyitoo]

Rust-Crypto's libraries removes armv8 and neon since v0.10: shadowsocks/shadowsocks-crypto@bae4a37 .

armv8 = ["aes-gcm/armv8", "aes/armv8", "aes-gcm-siv/armv8"]
neon = ["chacha20/neon"]

The ghash crate removes armv8 since this commit: RustCrypto/universal-hashes@636772c .

chacha20 still require neon feature to be set explicitly: RustCrypto/stream-ciphers@6217574 .

aes removes armv8 right after aarch64 intrinsic stablized.

I couldn't remember why we still need nightly after Feb. :(

[Mygod]

Shouldn't the neon flag be kept/enabled then?

[zonyitoo]

Shouldn't the neon flag be kept/enabled then?

Yes, I think we should. NEON is required for standard ARMv8 implementations: https://developer.arm.com/documentation/den0024/a/AArch64-Floating-point-and-NEON .

But why they still kept the neon feature? I should open an issue.

[zonyitoo]

Well, they know: RustCrypto/stream-ciphers#310 . Maybe the only reason is for keeping MSRV unchanged in the current version.

[Mygod]

Great. So let's add it (back) to shadowsocks-crypto?

[zonyitoo]

chacha20 with neon didn't release yet. I will keep my eyes on them.

[Mygod]

Maybe we could send them a friendly reminder. :)

EDIT: Done.