Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin 1.3.2 #2398

Merged
merged 5 commits into from
Jan 11, 2020
Merged

Plugin 1.3.2 #2398

merged 5 commits into from
Jan 11, 2020

Conversation

Mygod
Copy link
Contributor

@Mygod Mygod commented Jan 4, 2020 •
edited
Loading

Fixes #2391.

@Mygod Mygod requested a review from madeye January 4, 2020 09:30
@Mygod Mygod mentioned this pull request Jan 4, 2020
Closed
@Mygod Mygod changed the title Plugin next version Plugin 1.3.2 Jan 9, 2020
@Mygod Mygod added the plugin label Jan 9, 2020
@Mygod Mygod marked this pull request as ready for review January 9, 2020 09:37
@Mygod Mygod requested a review from madeye January 9, 2020 14:30
madeye
madeye approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@madeye madeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madeye madeye merged commit 0041164 into master Jan 11, 2020
@Mygod Mygod deleted the patch-2391 branch January 12, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madeye madeye madeye approved these changes

Assignees
No one assigned
Labels
plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin: onInitializePluginOptions(): first key with null value will disappear
2 participants
@Mygod @madeye