Plugin 1.3.4 #2431
Merged
Plugin 1.3.4 #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test this change, I think we need to update the plugin app accordingly? |
|
Done. |
|
To test 4a6dc80, we could test against GoQuiet-android. |
|
I tested it locally and found one issue. In the profile fragment, after switching the plugin, the option didn't get updated. Then saving the profile and open the profile again, the plugin option is updated. |
madeye
reviewed
Feb 6, 2020
Mygod
commented
Feb 6, 2020
|
Cool. Let's merge this for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change: support plugin aliases proposed by @CzBiX: shadowsocks/v2ray-plugin-android#18 (comment)
For other changes, see CHANGES.md.
I have not thoroughly tested this. @madeye Can you help? (client app should not require a plugin lib update)