Use local_dns_path #211
Merged
Use local_dns_path #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonyitoo
reviewed
Mar 15, 2020
zonyitoo
reviewed
Mar 15, 2020
|
|
|
Yes... Please do wait for me to catch up... |
zonyitoo
force-pushed
the
master
branch
10 times, most recently
from
1685e5b to
7fcc952
Compare
15 tasks
zonyitoo
force-pushed
the
master
branch
2 times, most recently
from
581818f to
a1b584e
Compare
|
After days of local testing, I think shadowsocks-rust works properly on Android now. No function issue or memory leak observed. Let's review this change again and hope it get merged soon. |
|
LGTM. |
|
I think we can merge this for now and worry about features later. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran out of time today... I will post this WIP here just in case any of you want to continue refactoring the code... :)