Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip symbols in release mode #750

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

Y0ba
Copy link
Contributor

@Y0ba Y0ba commented Jan 22, 2022

Adds strip option since it was stabilized. Closes #276.

@zonyitoo zonyitoo merged commit c3f52ee into shadowsocks:master Jan 22, 2022
@zonyitoo
Copy link
Collaborator

BTW, should we use strip = "symbols" instead of just strip = true?

@Y0ba
Copy link
Contributor Author

Y0ba commented Jan 22, 2022

It's same. Per documentation:

You can also configure this option with the two absolute boolean values
true and false. The former enables strip at its higher level, symbols

You can change it to "symbols" if you want to be more explicit.

@Y0ba Y0ba deleted the add_strip branch January 22, 2022 09:56
zonyitoo added a commit that referenced this pull request Jan 27, 2022
- #750 introduced strip=true, but it can only be used in >= 1.59
zonyitoo added a commit that referenced this pull request Jan 27, 2022
- #750 introduced strip=true, but it can only be used in >= 1.59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would you please strip for release assets?
2 participants