Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI has scrollbars by default #1922

Open
f1amy opened this issue Dec 27, 2024 · 12 comments
Open

Settings UI has scrollbars by default #1922

f1amy opened this issue Dec 27, 2024 · 12 comments
Labels

Comments

@f1amy
Copy link
Contributor

f1amy commented Dec 27, 2024

General Settings UI as of this commit shows vertical and horizontal scrollbars on English language, and even more so on other, like Russian.
Could this be caused by #1920?

Steps to reproduce:

  1. Download build https://github.com/shadps4-emu/shadPS4/releases/tag/Pre-release-shadPS4-2024-12-27-9b8de8d
  2. Open emulator, select games folder
  3. Open settings

What happens:
General tab settings UI has scrollbars

What should happen:
No scrollbars, the window is large enough for scrollbars to not appear

image

@f1amy
Copy link
Contributor Author

f1amy commented Dec 27, 2024

cc @f8ith

@Hermiten
Copy link
Collaborator

That true, same for me but I think was cause by something older because it was like this on the last 0.4.1

@Hermiten
Copy link
Collaborator

Try with a fresh install, I cannot reproduce it with a fresh one

@f1amy
Copy link
Contributor Author

f1amy commented Dec 27, 2024

Edited to add repro steps

@GHU7924
Copy link

GHU7924 commented Dec 27, 2024

In general, something strange is happening with the interface.

Before
050

After
051

I've seen this moment before
000

Did I miss something, or are these really some problematic points?

@f8ith
Copy link
Contributor

f8ith commented Dec 27, 2024

Settings dialog was very borked originally, my PR fixed some parts but might've left others unfixed. There is a lot of hard-coded geometry for some reason, I'm working to resolve the issues.

@DanielSvoboda
Copy link
Contributor

I'm putting together a PR to translate "MB, GB, h, m, s.", I can change the size of the settings screen, as it involves a gui...

@Hermiten
Copy link
Collaborator

We need something responsive rather than a size, I think, because a size is hardcoded, no ?

@DanielSvoboda
Copy link
Contributor

Here are some of my opinions about the interface.
The size fits without having to write numbers is the best thing to do.
On the 'Game Folder' screen I think there could be another 'Edit' button or in the list where the folder names are listed there could be a 'checkbox' to enable and disable them.
In 'General' I think 'Logger' could go from there and go to Debug.
Maybe redistribute the position in 'General' something similar to the print below, it was just a sketch, it can be improved more.

image

@GHU7924
Copy link

GHU7924 commented Dec 27, 2024

@DanielSvoboda Wow, I like your version.

On the 'Game Folder' screen I think there could be another 'Edit' button or in the list where the folder names are listed there could be a 'checkbox' to enable and disable them.

Can you make a sketch?

"Logger" go to Debug - I agree.

@DanielSvoboda
Copy link
Contributor

Today I will be busy, but from tomorrow I can open a PR with the new positions

@f8ith
Copy link
Contributor

f8ith commented Dec 30, 2024

Without geometry, I believe QScrollArea still needs to have a manually set minimum size, otherwise the dialog box will be tiny by default. We could get size hints on individual group boxes/layouts and then calculate the required minimum size that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants