-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liverpool: Flush vulkan work on task finish #1802
base: main
Are you sure you want to change the base?
Conversation
I get worse performance in Bloodborne with this PR with my NVIDIA GPU. Tested in the Hunter's Dream. There's very noticeable stutters with this PR when moving the camera around, I'll see if I can get a video comparison later on but it would be nice if someone else could do some testing. |
Tested a bit with Bloodborne too, didn't notice better or worse performance tbh, nor stutters (beside the ones that you can notice in the base game), but my rig is also a bit overpowered , would be nice like dcealopez said to have more testers |
With my Intel CPU-Nvidia GPU i get 2 fps more in Yakuza 0 and RE4, both games that are very heavy Yakuza 0 13 on main 15 on PR |
Tested with my NVIDIA GTX1650. mainmain.mp4PRfull.speed.mp4 |
So what is the consensus on this, is it worth it? |
I tried both latest main and this pr again playing Bloodborne and I noticed no difference, I think if that helps for some users it could be worth it, would like to know if @dcealopez still gets stutters on this PR. |
On high end systems this wont make a difference so mostly on low end how it performs. On the updated videos fps is the same but seems gpu usage is lower on PR |
I've also tested Bloodborne but couldn't really come to a conclusion. Maybe someone can try other intensive games? |
Ran MangoHUD for 5 minutes in two locations in Bloodborne, stationary, both with and with this patch. My system is a 5600X + 7900XT, on Linux, with recent mesa-git and kernel. Central Yharnam, looking towards great bridge:
Iosefka's Clinic lamp
Overall results do not exactly seem to be great. |
If there's any additional debug/profiling information that may be useful, let me know and I'll try to grab it |
This pr also causes some reshade effects to flicker on the screen. As the same but slighly less than the one when enabling ps4 pro function, even with the ps4 pro function disable the reshade effects will cause flickering and is not happening on main |
These two checkboxes fixes the depth buffer detection at the cost of a couple of frames. 2024-12-20.08-04-46.mp4 |
@RuskyDed What is that overlay? |
This is Reshade with SMAA's debug edges view |
Ensures we feed the GPU work more frequently, by increasing frequency of submissions from entire frame to once every submitted command list. Should give small performance boost to heavy 3D games or games that submit a lot of commands