Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liverpool: Flush vulkan work on task finish #1802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raphaelthegreat
Copy link
Collaborator

Ensures we feed the GPU work more frequently, by increasing frequency of submissions from entire frame to once every submitted command list. Should give small performance boost to heavy 3D games or games that submit a lot of commands

@dcealopez
Copy link
Contributor

I get worse performance in Bloodborne with this PR with my NVIDIA GPU. Tested in the Hunter's Dream. There's very noticeable stutters with this PR when moving the camera around, I'll see if I can get a video comparison later on but it would be nice if someone else could do some testing.

@Missake212
Copy link

Tested a bit with Bloodborne too, didn't notice better or worse performance tbh, nor stutters (beside the ones that you can notice in the base game), but my rig is also a bit overpowered , would be nice like dcealopez said to have more testers

@bigol83
Copy link
Contributor

bigol83 commented Dec 16, 2024

With my Intel CPU-Nvidia GPU i get 2 fps more in Yakuza 0 and RE4, both games that are very heavy

Yakuza 0 13 on main 15 on PR
Re4 34 on main 36 on PR

@ngoquang2708
Copy link
Contributor

ngoquang2708 commented Dec 16, 2024

Tested with my NVIDIA GTX1650.
Edit: Updated main video.

main
main.mp4
PR
full.speed.mp4

diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 16, 2024
diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 16, 2024
diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 16, 2024
@raphaelthegreat
Copy link
Collaborator Author

So what is the consensus on this, is it worth it?

@Missake212
Copy link

Missake212 commented Dec 18, 2024

I tried both latest main and this pr again playing Bloodborne and I noticed no difference, I think if that helps for some users it could be worth it, would like to know if @dcealopez still gets stutters on this PR.

@raphaelthegreat
Copy link
Collaborator Author

On high end systems this wont make a difference so mostly on low end how it performs. On the updated videos fps is the same but seems gpu usage is lower on PR

@rafael-57
Copy link
Contributor

I've also tested Bloodborne but couldn't really come to a conclusion. Maybe someone can try other intensive games?

@R1chterScale
Copy link

R1chterScale commented Dec 18, 2024

Ran MangoHUD for 5 minutes in two locations in Bloodborne, stationary, both with and with this patch. My system is a 5600X + 7900XT, on Linux, with recent mesa-git and kernel.

Central Yharnam, looking towards great bridge:

Stat Base PR-1802
0.1% 51.1fps 48.6fps
1% 69.1fps 61.7fps
97% 120.7fps 120.5fps
Avg 94.3fps 89.4fps

Iosefka's Clinic lamp

Stat Base PR-1802
0.1% 38.2fps 35.1fps
1% 40.9fps 39.4fps
97% 60.2fps 60.2fps
Avg 54.7fps 52.2fps

Overall results do not exactly seem to be great.

@R1chterScale
Copy link

If there's any additional debug/profiling information that may be useful, let me know and I'll try to grab it

@diegolix29
Copy link

This pr also causes some reshade effects to flicker on the screen. As the same but slighly less than the one when enabling ps4 pro function, even with the ps4 pro function disable the reshade effects will cause flickering and is not happening on main

@RuskyDed
Copy link

RuskyDed commented Dec 20, 2024

This pr also causes some reshade effects to flicker on the screen. As the same but slighly less than the one when enabling ps4 pro function, even with the ps4 pro function disable the reshade effects will cause flickering and is not happening on main

These two checkboxes fixes the depth buffer detection at the cost of a couple of frames.

2024-12-20.08-04-46.mp4

@ngoquang2708
Copy link
Contributor

@RuskyDed What is that overlay?

@RuskyDed
Copy link

RuskyDed commented Dec 20, 2024

@RuskyDed What is that overlay?

This is Reshade with SMAA's debug edges view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants