Extend IREmitter::INotEqual to handle U64s #1824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| switch (lhs.Type()) { | ||
| case Type::U32: | ||
| case Type::U64: | ||
| return Inst<U1>(Opcode::INotEqual, lhs, rhs); |
There was a problem hiding this comment.
INotEqual is defined as having U32 inputs
shadPS4/src/shader_recompiler/ir/opcodes.inc
Line 307 in be4c38b
I suspect if you compile in debug mode it will assert on mismatched types if passed U64
There was a problem hiding this comment.
I'm pretty sure it didn't assert there in debug 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.