Implement IMAGE_GATHER4 and IMAGE_GATHER4_O #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by The Last of Us Remastered.
Had a different set of types compared to the other IMAGE_GATHER4 ops.
|
Thanks, these are also used by Driveclub CUSA00003 so was meaning to add them, nice to have |
Younes-Bel
pushed a commit
to Younes-Bel/shadPS4
that referenced
this pull request
Dec 29, 2024
* Implement IMAGE_GATHER4_O Used by The Last of Us Remastered. * Fix type on IMAGE_GATHER4_C_LZ Had a different set of types compared to the other IMAGE_GATHER4 ops. * IMAGE_GATHER4
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 29, 2024
* Implement IMAGE_GATHER4_O Used by The Last of Us Remastered. * Fix type on IMAGE_GATHER4_C_LZ Had a different set of types compared to the other IMAGE_GATHER4 ops. * IMAGE_GATHER4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two opcodes are encountered in CUSA00556 - The Last of Us™ Remastered. Also fixes an oddity with the IMAGE_GATHER4_C_LZ entry in our instruction format table. Let me know if there's anything I need to change.
Credits to @Missake212 for testing these changes.