Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Switch to Windows 2025 & Reduce Warnings #2052

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Xphalnos
Copy link
Collaborator

@Xphalnos Xphalnos commented Jan 4, 2025

  • Upgrade to Windows 2025 because windows-latest uses windows-2022 by default
  • Added -DCMAKE_C_FLAGS_RELEASE=-Ofast -DCMAKE_CXX_FLAGS_RELEASE=-Ofast because by default it uses the -O3 optimization (-Ofast uses the -O3 optimizations but with additional ones)

Main:
Before1

This PR:
After1

  • 3 Warnings less by replacing ubuntu-latest with ubuntu-24.04
    CI-Warnings

@polybiusproxy
Copy link
Collaborator

Is there any specific reason to move to a runner image in public preview?

@Xphalnos
Copy link
Collaborator Author

Xphalnos commented Jan 4, 2025

Is there any specific reason to move to a runner image in public preview?

It contains more up-to-date packages for example LLVM and also it uses the latest Windows SDK

  • Windows 2022 => 10.0.20348
  • Windows 2025 => 10.0.26100

@MajorP93
Copy link
Contributor

MajorP93 commented Jan 4, 2025

There are multiple reasons why adding DCMAKE_C_FLAGS_RELEASE=-Ofast and DCMAKE_CXX_FLAGS_RELEASE=-Ofast is not a good idea:

  • -Ofast compiler flag is deprecated in Clang 20
  • Can introduce issues since some mathematical operations behave differently when this flag is added
  • Setting DCMAKE_C_FLAGS_RELEASE (and the respective CXX variant) in this case will overwrite other compiler flags. The option is not being appended to compiler flags but rather replacing the whole line of compiler flags during compilation.

@Xphalnos Xphalnos force-pushed the Build_Optimisation branch from 121441b to f001ca1 Compare January 5, 2025 10:35
@Xphalnos
Copy link
Collaborator Author

Xphalnos commented Jan 5, 2025

I trust you. So let's remove the optimizations.

@Xphalnos Xphalnos changed the title CI: Optimization Flags & Switch to Windows 2025 CI: Switch to Windows 2025 & Reduce Warnings Jan 5, 2025
@georgemoralis georgemoralis merged commit 869bf85 into shadps4-emu:main Jan 7, 2025
10 checks passed
@Xphalnos Xphalnos deleted the Build_Optimisation branch January 8, 2025 12:29
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants