Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Exceptions #955

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft: Exceptions #955

wants to merge 1 commit into from

Conversation

vladmikhalin
Copy link
Collaborator

What needs to be done:

  • Any synchronization code that can be called from any game thread should be re-written to be interruptable/alertable where applicable (using either pthreads or native API).
  • Investigate why raising an exception does nothing although signal callback is called on the desired thread. Probably something to do with context structure not having some info.

@vladmikhalin vladmikhalin marked this pull request as draft September 17, 2024 06:01
squidbus
squidbus reviewed Sep 17, 2024
View reviewed changes
src/core/libraries/kernel/thread_management.cpp
.value = {static_cast<int>(value)},
};
int PS4_SYSV_ABI posix_sem_init(sem_t* sem, int pshared, unsigned int value) {
int result = sem_init(sem, pshared, value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be used on macOS, unnamed POSIX semaphores are not implemented.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was just an experiment to make evStart from pthreads to alert the thread. This should be removed and re-worked either way. We cannot use winpthreads anyway as it does not provide the required functionality.

@ArbestRi02
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidbus squidbus squidbus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladmikhalin @ArbestRi02 @squidbus