Shortening GPG key ID of torproject.org to 16 characters.

[rejozenger]

Module puppet-tor relies on module puppetlabs-apt for managing apt repository for torproject.org. The module now specifies the GPG key of the Tor Project as a 32 character string, while the apt module of Puppetlabs validates key ID's of 8 or 16 characters long only).

[shaftoe]

Thanks for noticing this. Seems that they are currently addressing the issue: puppetlabs/puppetlabs-apt#354
I'd rather see that limitation fixed, because I am quite sure the Tor community won't be happy to use anything but the fingerprint.
Which version of puppetlabs-apt are you running by the way?

[rejozenger]

I am using version 1.4.2, the one you get when installing the module using the "puppet module install" command. And yes, of course I would rather see the upstream fix the issue (and they are currently in the process of doing so it appears). But for the mean time I needed the fix I made the pull request for. If I didn't, your module simply doesn't work.

[shaftoe]

Weird, I'm testing with a Debian Vagrant box and it works for me:
==> default: Notice: /Stage[main]/Tor::Apt/Apt::Key[A3C4F0F979CAA22CDBA8F512EE8CBC9E886DDD89]/Exec[549b2f53f44a78f7874dc11817eed0d4d01cf652]/returns: executed successfully

By the way, I should also update the dependency to use the most recent version of puppetlabs-apt. Could you maybe try that and see if it works for you?

[rejozenger]

When I remove puppetlabs-stdlib, puppetlabs-apt and fortin-tor modules, then re-install your module using the command "puppet module install fortin-tor", I get:

/etc/puppet/environments/production/modules
└─┬ fortin-tor (v0.1.0)
  └─┬ puppetlabs-apt (v1.4.2)
    └── puppetlabs-stdlib (v4.5.0)

I can't upgrade due to some issue between the two puppetlabs modules:

Error: Could not upgrade module 'puppetlabs-apt' (v1.4.2 -> latest)
  There are 5 newer versions
    No combination of dependency upgrades would satisfy all dependencies
    Dependencies will not be automatically upgraded across major versions
    Upgrading one or more of these modules may permit the upgrade to succeed:
    - puppetlabs-stdlib
    Use `puppet module upgrade --force` to upgrade only this module

Didn't have the time to investigate that.

[shaftoe]

Right, thanks for the effort so far. I'll try to spare some time in those festivities to do some proper testing and keep this issue up to date

[shaftoe]

Sorry for the late, I totally forgot about this. I've merged a new patch about puppetlabs-apt versions and I hope it's already addressing the issue (I feel lucky today :-))