Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in content/07a_opcodes/02_math.ipynb #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0x6980
Copy link

@0x6980 0x6980 commented Aug 17, 2024

In the function mulmod(evm)

def mulmod(evm):
    a, b = evm.stack.pop(), evm.stack.pop()
    N = evm.stack.pop()
    evm.stack.push((a + b) * N)
    evm.pc += 1
    evm.gas_dec(8)

this part evm.stack.push((a + b) * N) should be evm.stack.push((a * b) % N)

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for evm-from-scratch ready!

Name Link
🔨 Latest commit 2af24b6
🔍 Latest deploy log https://app.netlify.com/sites/evm-from-scratch/deploys/66c0f6a8b71b050008809c26
😎 Deploy Preview https://deploy-preview-19--evm-from-scratch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant