Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating few REST API endpoints #119

Merged
merged 30 commits into from
Jan 28, 2024

Conversation

shahariaazam
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Please provide some description about your PR.

Related Issue (if applicable)

Fixes #118

Added tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Relevant Documentation updated?

  • [Docs](link to the docs pr)
  • Did not update documentation

@shahariaazam shahariaazam self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (dcebf32) 62.50% compared to head (a4a163f) 64.03%.

Files Patch % Lines
pkg/storage/postgresql.go 0.00% 36 Missing ⚠️
pkg/api/resource_handler.go 74.69% 15 Missing and 6 partials ⚠️
cmd/discover.go 70.58% 14 Missing and 6 partials ⚠️
pkg/storage/storage.go 55.00% 17 Missing and 1 partial ⚠️
pkg/resource/resource.go 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   62.50%   64.03%   +1.53%     
==========================================
  Files          22       23       +1     
  Lines        1576     1771     +195     
==========================================
+ Hits          985     1134     +149     
- Misses        513      551      +38     
- Partials       78       86       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

argos-ci bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 34 changes Jan 28, 2024, 10:33 PM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
47.9% Coverage on New Code (required ≥ 60%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@shahariaazam shahariaazam merged commit 02a86ca into master Jan 28, 2024
10 of 11 checks passed
@shahariaazam shahariaazam deleted the terediX-118-create-REST-api-endpoing branch January 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create REST api endpoint
1 participant