Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy configuration from different sources #15

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

shahariaazam
Copy link
Member

Added support to copy configuration from different sources.

  • config_from configuration key added to copy configuration from other source in config yaml file

It will reduce complexity to maintain config.yaml file. For example, you can use same credentials to fetch AWS resources (rds, s3, etc..). Adding same credentials for different resource types should be avoided

…ation, we can make multiple source for each types without defining separate configuration
…configuration, we can make multiple source for each types without defining separate configuration"

This reverts commit 88228b4.
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.29 🎉

Comparison is base (7a88fb8) 71.54% compared to head (ea80e05) 71.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   71.54%   71.84%   +0.29%     
==========================================
  Files          13       13              
  Lines         949      959      +10     
==========================================
+ Hits          679      689      +10     
  Misses        235      235              
  Partials       35       35              
Impacted Files Coverage Δ
pkg/config/config.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@shahariaazam shahariaazam merged commit 748a8d4 into master Apr 2, 2023
@shahariaazam shahariaazam deleted the aws_config_allow_different_resource_types branch April 2, 2023 12:39
@shahariaazam shahariaazam added this to the First stable release milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant