fix: Add stdout validation when setting logging output path (sourcene…

…twork#666)

Relevant issue(s)
Resolves sourcenetwork#665

Description
This PR fixes the outputPath validation for the logging package. It ensures an stdout file isn't created during validation.

logging/config.go

@@ -33,6 +33,7 @@ func NewEncoderFormatOption(v EncoderFormat) EncoderFormatOption {
 
 const (
 	stderr = "stderr"
+	stdout = "stdout"
 
 	JSON EncoderFormat = iota
 	CSV
@@ -238,12 +239,12 @@ func (oldConfig Config) with(newConfigOptions Config) Config {
 func validatePaths(paths []string) []string {
 	validatedPaths := make([]string, 0, len(paths))
 	for _, p := range paths {
-		if p == stderr {
+		if p == stderr || p == stdout {
 			validatedPaths = append(validatedPaths, p)
 			continue
 		}
 
-		if f, err := os.OpenFile(p, os.O_CREATE|os.O_APPEND, 0666); err != nil {
+		if f, err := os.OpenFile(p, os.O_CREATE|os.O_APPEND, 0644); err != nil {
 			log.Info(context.Background(), "cannot use provided path", NewKV("err", err))
 		} else {
 			err := f.Close()
@@ -258,12 +259,12 @@ func validatePaths(paths []string) []string {
 	return validatedPaths
 }
 
-func willOutputToStderr(paths []string) bool {
+func willOutputToStderrOrStdout(paths []string) bool {
 	if len(paths) == 0 {
 		return true
 	}
 	for _, p := range paths {
-		if p == stderr {
+		if p == stderr || p == stdout {
 			return true
 		}
 	}

logging/logger.go

@@ -150,7 +150,7 @@ func (l *logger) ApplyConfig(config Config) {
 	_ = l.logger.Sync()
 	l.logger = newLogger
 
-	if !willOutputToStderr(config.OutputPaths) {
+	if !willOutputToStderrOrStdout(config.OutputPaths) {
 		if config.pipe != nil { // for testing purposes only
 			l.consoleLogger = stdlog.New(config.pipe, "", 0)
 		} else {
@@ -209,7 +209,7 @@ func buildZapLogger(name string, config Config) (*zap.Logger, error) {
 		return nil, err
 	}
 
-	if willOutputToStderr(defaultConfig.OutputPaths) && config.pipe != nil {
+	if willOutputToStderrOrStdout(defaultConfig.OutputPaths) && config.pipe != nil {
 		newLogger = newLogger.WithOptions(zap.WrapCore(func(zapcore.Core) zapcore.Core {
 			cfg := zap.NewProductionEncoderConfig()
 			cfg.ConsoleSeparator = defaultConfig.EncoderConfig.ConsoleSeparator