Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to run executable via NPM module on Apple Silicon (even with Rosetta 2 enabled) #1375

Closed
vitalygashkov opened this issue Mar 20, 2024 · 1 comment · Fixed by #1376 or #1377
Closed

Unable to run executable via NPM module on Apple Silicon (even with Rosetta 2 enabled) #1375

vitalygashkov opened this issue Mar 20, 2024 · 1 comment · Fixed by #1376 or #1377
Assignees
@vitalygashkov
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: CI An issue with our continuous integration tests
Milestone
v3.0

Comments

@vitalygashkov
Copy link
Contributor

System info

Operating System: macOS Sonoma 14.3.1 (23D60)
Shaka Packager Version: v3.0.3

Issue and steps to reproduce the problem

(1) Find a Mac computer running Apple Silicon chips.
(2) On this Mac create a Node.js project with index.js file, install the npm package shaka-packager, then try to call installed module in that index.js file: require('shaka-packager').

What is the expected result?
Macs on M chips have Rosetta 2 technology, which makes it possible to seamlessly run applications with x64 architecture. I would like to be able to run the executable on Apple Silicon: either allow the mac x64 build to run, or add a mac arm64 variant to the builds.

What happens instead?
An error occurs when I call a module from Node.js script.

/Users/user/project/node_modules/shaka-packager/index.js:28
  throw new Error(
  ^

Error: Architecture not supported: darwin/arm64
    at Object.<anonymous> (/Users/user/project/node_modules/shaka-packager/index.js:28:9)
@vitalygashkov vitalygashkov mentioned this issue Mar 20, 2024
Merged
@joeyparrish joeyparrish added type: bug Something isn't working correctly type: CI An issue with our continuous integration tests priority: P2 Smaller impact or easy workaround labels Mar 20, 2024
@joeyparrish
Copy link
Member

Thank you for the PR!

@github-actions github-actions bot added this to the v3.0 milestone Mar 20, 2024
joeyparrish pushed a commit that referenced this issue Mar 21, 2024
@vitalygashkov
fix: Fix NPM binary selection on ARM Macs (#1376)
733af91 
Fixes #1375
@shaka-bot shaka-bot mentioned this issue Mar 21, 2024
Merged
joeyparrish pushed a commit that referenced this issue Mar 27, 2024
@shaka-bot
chore(main): release 3.0.4 (#1377)
ceeb378 
🤖 I have created a release *beep* *boop*
---


## [3.0.4](v3.0.3...v3.0.4) (2024-03-27)


### Bug Fixes

* BaseURL missing when MPD base path is empty ([#1380](#1380)) ([90c3c3f](90c3c3f)), closes [#1378](#1378)
* Fix NPM binary selection on ARM Macs ([#1376](#1376)) ([733af91](733af91)), closes [#1375](#1375)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vitalygashkov vitalygashkov

Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: CI An issue with our continuous integration tests
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

fix: Fix NPM binary selection on ARM Macs
chore(main): release 3.0.4 shaka-project/shaka-packager
2 participants
@joeyparrish @vitalygashkov