Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for MHA1 audio on packager #930

Closed
nvincen opened this issue Apr 12, 2021 · 1 comment · Fixed by #952
Closed

Support for MHA1 audio on packager #930

nvincen opened this issue Apr 12, 2021 · 1 comment · Fixed by #952
Assignees
@nvincen
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.6

Comments

@nvincen
Copy link
Contributor

nvincen commented Apr 12, 2021

System info

Operating System: <e.g. macOS Sierra, Ubuntu 14.04 trusty etc>
AmazonLinux
Shaka Packager Version: <e.g. v1.6.1, commit SHA etc>
6c8ad30217c286d4eecadc9df12420767d389942

Issue and steps to reproduce the problem

Packager Command:

docker run -it -v /tmp:/media local_registry:DigitalMusicShakaPackager-1.0-1618201405.1419096 packager "in=/media/TempMHA1.mp4,stream=audio,output=/media/output/TempMHA1.mp4" --fragment_duration 10 --segment_duration 10 --clear_lead 10 --v=-1 --generate_static_mpd --mpd_output /media/output/manifest-3.mpd

Extra steps to reproduce the problem?
(1) Run with MP4 content that contains MHA1 audio.

What is the expected result?
Would like support for the MHA1 audio type

What happens instead?
Error with unsupported audio format, see error log:

[0412/222408:WARNING:mp4_media_parser.cc(519)] Unsupported audio format 'mha1' in stsd box.
[0412/222408:ERROR:audio_stream_info.cc(143)] Not implemented reached in static std::string shaka::media::AudioStreamInfo::GetCodecString(shaka::media::Codec, uint8_t)Codec: 0
[0412/222408:ERROR:mp4_muxer.cc(517)] Not implemented reached in bool shaka::media::mp4::MP4Muxer::GenerateAudioTrak(const shaka::media::AudioStreamInfo *, shaka::media::mp4::Track *) Unsupported audio codec 0
[0412/222408:ERROR:demuxer.cc(356)] Failed to process sample 512 11 (MUXER_FAILURE): Failed to generate trak.
[0412/222408:ERROR:mp4_media_parser.cc(879)] Failed to process the sample.
[0412/222408:ERROR:packager_main.cc(550)] Packaging Error: 8 (PARSER_FAILURE): Cannot parse media file /media/TempMHA1.mp4

<Please attach the input files or email to shaka-packager-issues@google.com.>
@kqyang
Copy link
Contributor

kqyang commented Apr 12, 2021

Correct, MHA1 is not supported. Let us know if you are interested in helping us implement it. Contributions are appreciated!

@kqyang kqyang added type: enhancement New feature or request flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this and removed needs triage labels Apr 12, 2021
@shaka-bot shaka-bot added this to the Backlog milestone Apr 12, 2021
@nvincen nvincen mentioned this issue Apr 17, 2021
Closed
@nvincen nvincen mentioned this issue Jun 9, 2021
Merged
kqyang pushed a commit that referenced this issue Jun 30, 2021
@nvincen
Added MPEG-H support (mha1, mhm1)
f018c9a 
Implemented according to `Audio Amendment to Guidelines for Implementation:
DASH-IF Interoperability Points, Version 4.3`
(https://dashif.org/docs/Audio%20Amendment%20to%20DASH%20IOP%204.3.pdf).

Closes #930.
@kqyang kqyang modified the milestones: Backlog, v2.6 Jun 30, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 3, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Sep 3, 2021
sr1990 pushed a commit to sr1990/shaka-packager that referenced this issue Feb 18, 2023
@nvincen @sr1990
Added MPEG-H support (mha1, mhm1)
847683f 
Implemented according to `Audio Amendment to Guidelines for Implementation:
DASH-IF Interoperability Points, Version 4.3`
(https://dashif.org/docs/Audio%20Amendment%20to%20DASH%20IOP%204.3.pdf).

Closes shaka-project#930.
sr1990 pushed a commit to sr1990/shaka-packager that referenced this issue Feb 18, 2023
@nvincen @sr1990
Added MPEG-H support (mha1, mhm1)
1cbb0a1 
Implemented according to `Audio Amendment to Guidelines for Implementation:
DASH-IF Interoperability Points, Version 4.3`
(https://dashif.org/docs/Audio%20Amendment%20to%20DASH%20IOP%204.3.pdf).

Closes shaka-project#930.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nvincen nvincen

Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Add MPEG-H support nvincen/shaka-packager
Add support for MHA1 and MHM1 nvincen/shaka-packager
3 participants
@kqyang @shaka-bot @nvincen