Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add input support for EBU Teletext in MPEG-TS #1181

Closed
wants to merge 2 commits into from
Closed

feat: Add input support for EBU Teletext in MPEG-TS #1181

wants to merge 2 commits into from

Conversation

marcusspangenberg
Copy link
Contributor

  • Add support for EBU Teletext input following Level 1.5 of the core specification ETSI EN 300 706 V1.2.1 (2003-04).
  • Add support for webvtt in MP4 segments output.

Implements #272

@marcusspangenberg
feat: Add input support for EBU Teletext in MPEG-TS
7434b01 
Supports EBU Teletext input following Level 1.5 of the
core specification ETSI EN 300 706 V1.2.1 (2003-04).
@marcusspangenberg
fix: Support webvtt in mp4 segments as output.
d6423c1
@Nixon197
Copy link

I tested Teletext implementation with live UDP input and it looks good.

acris5
acris5 approved these changes Oct 25, 2023
View reviewed changes
Copy link

@acris5 acris5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally this feature works well

packager/media/formats/mp2t/es_parser_teletext.cc
return false;

} else if (packet_nr > 26) {
return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packet28 has more language codec infos, so it's advisible to parse it and change teletext G0 charset accordingly

@acris5
Copy link

acris5 commented Jan 25, 2024

@marcusspangenberg I updated your code with cmake build changes in upstream, and also added additional languages support. Please, take a look on this patch (it is a diff from main)
teletext.zip

@Brainiarc7 Brainiarc7 mentioned this pull request Jan 29, 2024
Closed
@joeyparrish
Copy link
Member

Please merge with main, which has changed a lot in the recent cmake port. Thanks!

@cosmin cosmin mentioned this pull request Feb 15, 2024
Merged
@cosmin
Copy link
Contributor

cosmin commented Feb 15, 2024

Moving to #1344

@cosmin cosmin closed this Feb 15, 2024
@cosmin
Copy link
Contributor

cosmin commented Feb 15, 2024

@acris5 I moved this pull request (including rebasing it to latest main) to #1344. The additional language changes from your zip file look interesting as well, would you mind submitting that as a pull request (on top of #1344)?

joeyparrish pushed a commit that referenced this pull request Feb 23, 2024
@cosmin @marcusspangenberg
feat: Add input support for EBU Teletext in MPEG-TS (#1344)
71c175d 
Replaces #1181

* Add support for EBU Teletext input following Level 1.5 of the core
specification ETSI EN 300 706 V1.2.1 (2003-04).
* Add support for webvtt in MP4 segments output.

Closes #272

---------

Co-authored-by: Marcus Spangenberg <marcus.spangenberg@eyevinn.se>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acris5 acris5 acris5 approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcusspangenberg @Nixon197 @acris5 @joeyparrish @cosmin