Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issues with collections.abc in Python 3.10+ #1188

Merged
merged 1 commit into from
May 1, 2023

Conversation

Brainiarc7
Copy link
Contributor

@Brainiarc7 Brainiarc7 commented Mar 15, 2023

This issue is observed on Python 3.10+ and above.
This workaround addresses a major backwards compatibility break with a major Python release version where collections.abc isn't available.

Fixes #1192

This issue is observed on Python 3.10+ and above.
This workaround addresses a major backwards compatibility break with a major Python release version where collections.abc isn't available.
@Brainiarc7 Brainiarc7 changed the title -Fix: Python 3.10= issues with collections.abc fix: Resolves Python 3.10+ issues with collections.abc on modern Linux distributions Mar 16, 2023
@Brainiarc7
Copy link
Contributor Author

A cleaner solution to this would be updating the third-party module protobuf to v.4.0.x.
That release already incorporates a cleaner fix for this.
The release used in shaka-packager (at present) is 3.3.0 from 5 years ago.

@joeyparrish joeyparrish changed the title fix: Resolves Python 3.10+ issues with collections.abc on modern Linux distributions fix: Fix issues with collections.abc in Python 3.10+ May 1, 2023
@joeyparrish
Copy link
Member

The cmake branch, where we are overhauling the dependencies and the build system, uses source from around Protobuf v3.21.9 via git submodules. Does that version have the correct fixes, or should we bump to v4 in that branch?

I'll go ahead and merge this into main, but since it touches third-party code, and the cmake branch uses submodules, this can't be merged over to the cmake branch.

@joeyparrish joeyparrish merged commit 80e0240 into shaka-project:main May 1, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run-time issues on Ubuntu 22.04LTS due to python changes related to abc.collections, patch included.
2 participants