Skip to content

Commit

Permalink
ci: Work around msedgedriver 115+ bug (#5618)
Browse files Browse the repository at this point in the history
Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment)

This also incorporates
shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs.
  • Loading branch information
joeyparrish committed Sep 8, 2023
1 parent 5936898 commit 85a24c1
Show file tree
Hide file tree
Showing 3 changed files with 66 additions and 16 deletions.
7 changes: 7 additions & 0 deletions build/shaka-lab.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ vars:
excludeSwitches:
- "disable-component-update"

# Work around https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102#issuecomment-1710724173
# by specifying the binary path on Linux.
edge_linux_config: &edge_linux_config
ms:edgeOptions:
binary: /usr/bin/microsoft-edge

android_chrome_config: &android_chrome_config
goog:chromeOptions:
args:
Expand Down Expand Up @@ -180,6 +186,7 @@ EdgeLinux:
os: Linux
extra_configs:
- *basic_edge_config
- *edge_linux_config


### Misc ###
Expand Down
73 changes: 58 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"karma-coverage": "^2.2.0",
"karma-jasmine": "^4.0.1",
"karma-jasmine-ajax": "^0.1.13",
"karma-local-wd-launcher": "^1.6.4",
"karma-local-wd-launcher": "^1.6.6",
"karma-opera-launcher": "^1.0.0",
"karma-sourcemap-loader": "^0.3.8",
"karma-spec-reporter": "^0.0.34",
Expand Down

0 comments on commit 85a24c1

Please sign in to comment.