Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setPlaybackRate when video paused #138

Closed
sanbornhilland opened this issue Jul 27, 2015 · 3 comments
Closed

setPlaybackRate when video paused #138

sanbornhilland opened this issue Jul 27, 2015 · 3 comments
Labels
status: archived Archived and locked; will not be updated

Comments

@sanbornhilland
Copy link
Contributor

setPlaybackRate behaves inconsistently when paused. If a negative playbackrate is provided when the video is paused, then the video will start playing backwards. But if a value > 1 is given, nothing happens. I think the expected behaviour is that the video would start fast forwarding in the second case. It nicely handles the case where we want to fastforward while the video is paused and it makes setPlaybackRate consistent between fast forward and rewind.

@tdrews
Copy link
Contributor

tdrews commented Jul 27, 2015

Thanks for the report.

@tdrews
Copy link
Contributor

tdrews commented Jul 28, 2015

Yep Player.setPlaybackRate is inconsistent. However, I think the behavior should be consistent with how video.playbackRate works; for example,

video.pause();
video.playbackRate = 2;
// Stays paused until...
video.play();

So we should have

video.pause();
player.setPlaybackRate(2);
// Stays paused until...
video.play();

and

video.pause();
player.setPlaybackRate(-1);
// Stays paused until...
video.play();

@sanbornhilland
Copy link
Contributor Author

Yeah, that's a good point.

natalieharris added a commit that referenced this issue Aug 4, 2015
Change-Id: I6a4be5acd37b42fb92bddc896009ae48cb92b5ec
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

5 participants