Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline content not stored correctly. #157

Closed
tdrews opened this issue Aug 14, 2015 · 2 comments
Closed

Offline content not stored correctly. #157

tdrews opened this issue Aug 14, 2015 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@tdrews
Copy link
Contributor

tdrews commented Aug 14, 2015

Repro on Master and 1.4.0:

  • Store clear "Car" clip.
  • Load "Car" clip.
  • Seek to the end of the video or wait... the video will run out of data around 2:15.
@tdrews tdrews added the type: bug Something isn't working correctly label Aug 14, 2015
@joeyparrish joeyparrish added this to the v1.5.0 milestone Aug 17, 2015
@joeyparrish joeyparrish self-assigned this Aug 17, 2015
@joeyparrish joeyparrish changed the title Offline content does not play out correctly. Offline content not stored correctly. Aug 26, 2015
@joeyparrish
Copy link
Member

This bug affects all previous versions.

@joeyparrish
Copy link
Member

Correction: affects all previous versions with offline support, which means v1.3.0+.

joeyparrish added a commit that referenced this issue Sep 4, 2015
The final chunk was only being stored when the endTime of the final
segment happened to be null.  An index with explicit end times for
all segments, even on one stream, would trigger this bug.

For example, the end time of the final video segment may be null, but
the end time of the final audio segment may be equal to the content
duration.  The stored audio would be missing a chunk, causing the
computed stream limit to be too short on playback.

This corrects the off-by-one error in the storage code by explicitly
signalling when a segment is the last one, rather than checking for
a null endTime.

Closes #157

Change-Id: Ic99d53b9e2b071409d4d9472b8bc4ae0cf76f940
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants