Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromecast support in v2 #261

Closed
PyRo1509 opened this issue Jan 6, 2016 · 4 comments
Closed

Chromecast support in v2 #261

PyRo1509 opened this issue Jan 6, 2016 · 4 comments
Assignees
@ismena
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.0.0

Comments

@PyRo1509
Copy link

PyRo1509 commented Jan 6, 2016

To recreate:
Load demo Angel One w/ Subtitles.
Enable Subs, View/test on browser player. (WebVTT is included in manifest)
Choose various audio languages, perhaps cycle tracks

Cast to Chromecast, there are no subtitles and the audio will only be the default 'en' track.
@joeyparrish joeyparrish added the type: enhancement New feature or request label Jan 27, 2016
@joeyparrish joeyparrish self-assigned this Jan 27, 2016
@joeyparrish joeyparrish added this to the v2.0.0 milestone Jan 27, 2016
@joeyparrish
Copy link
Member

The current demo app does not support that yet. You may notice that those controls are disabled as soon as you cast.

Please note that casting is done completely outside the library and in the application. So you can already use the full range of Shaka features with the Chromecast in your own application, even though you can't see it in the demo.

With Shaka 2, we will organize the demo app in a way that shows all functionality both locally and on the Chromecast.

@joeyparrish joeyparrish changed the title Chromecast doesn't accept stream selections (specifically Audio and Subtitles) Chromecast demo for v2 Apr 8, 2016
@joeyparrish joeyparrish changed the title Chromecast demo for v2 Chromecast support in v2 May 6, 2016
@joeyparrish
Copy link
Member

In addition to showing Cast support in the demo app, we've decided to bring Cast support in-library for v2. We hope this makes it easier for users to build Cast receiver apps.

shaka-bot pushed a commit that referenced this issue Jul 6, 2016
@joeyparrish
v2 Chromecast support
0c8f744 
This introduces Chromecast support directly in the v2 library, as well
as in the demo app.

See the included design doc for details.

Issue #261

Change-Id: I26a707e7fa6bd829c3ebc70e4c9345ec25eed000
shaka-bot pushed a commit that referenced this issue Jul 6, 2016
@joeyparrish
Use the local Player for offline Storage
edae3a4 
It makes no sense to refer to the Cast-proxied Player for offline
storage, so explicitly refer to the local Player instead.

Issue #261

Change-Id: I6b4e0cb828489724d334362d6e15da3d3ea12719
shaka-bot pushed a commit that referenced this issue Jul 6, 2016
@joeyparrish
Disable the cast button during connection
27de37f 
Issue #261

Change-Id: If6dd1c06a51dfd77bea62fc757718d0e59c324d8
shaka-bot pushed a commit that referenced this issue Jul 6, 2016
@joeyparrish
Show Cast receiver device name
2dbadb1 
Issue #261

Change-Id: Ia91178810c5ad4d353b9c96e396fda2ba4bfcff2
shaka-bot pushed a commit that referenced this issue Jul 7, 2016
@joeyparrish
Limit Chromecast playback to 1080p
3624d8e 
Original Chromecast devices can output a max of 1080p, and may have
issues digesting higher resolution content.  Since higher resolution
content would be downscaled for display anyway, limit Chromecast to
1080p to avoid both decoder issues and wasted bandwidth.

Some Cast devices may support UHD content, but the max res for
Chromecast is currently hard-coded until we have a way to detect a
device's capabilities at runtime.

Issue #261

Change-Id: I3dd093b07f9a964116f81422f3c298dfbf7e2e52
shaka-bot pushed a commit that referenced this issue Jul 7, 2016
@joeyparrish
Fix race between Cast sender and receiver
b2fd140 
The sender is always polling video.buffered in the controls.  Before
the first update from the receiver, the sender should see local values
for video.buffered.  However, the receiver was updating volume events
before the first full update, leading the sender to try to access
remote values for video.buffered before they existed.  This caused
uncaught TypeErrors in the controls.

Issue #261

Change-Id: I3836315d136be4584c1140842720919bca5d57e2
shaka-bot pushed a commit that referenced this issue Jul 7, 2016
@joeyparrish
Cleanup cast idle state
3def381 
This simplifies the logic for idle state, fixes some buggy idle state
transitions, and moves the idle logic into CastReceiver (with a little
support from Player).

Issue #261

Change-Id: Ic2729a4235c746ad46353bdf5dc7b605ab31f3ef
@joeyparrish
Copy link
Member

This is mostly done. What we have so far will be in v2.0.0-beta3. What's not done yet, which we hope to finish in the final v2.0.0:

  • Support for casting from the Cast button built into latest Chrome, as opposed to the Cast button on the video controls
  • CSS3 animated buffering spinner appears to perform poorly on Chromecast

@joeyparrish joeyparrish removed their assignment Aug 29, 2016
@ismena ismena self-assigned this Aug 30, 2016
@joeyparrish
Copy link
Member

Split the CSS3 animation performance issue to #505, which will be deferred until after v2.0.0.

shaka-bot pushed a commit that referenced this issue Sep 2, 2016
@ismena
Delegate disconnecting from chromecast to Chrome.
b335c5a 
Show 'stop casting' dialog on chromecast control click when casting.
If user chooses to stop, delegate disconnecting to Chrome.

Related to #261

Change-Id: I3072a3723e0d0d526039946fb45713e20349e54c
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
4 participants
@PyRo1509 @ismena @joeyparrish @shaka-bot