-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some subtitles in the manifest are not shown in the player #3724
Comments
Do you see all three text tracks in |
Hey @joeyparrish, I opened a PR that fix the issue: #3725 |
Hey @joeyparrish, |
We filter out text streams that are duplicates, before persenting them to the end user. A duplicate is detected by checking if various values on the streams are the same. However, we were not checking for bandwidth. This could lead to a text stream being marked as a duplicate if it had the same language, label, etc as another, even if they did not contain the same text. This changes the utility to also check bandwidth. Closes #3724
We filter out text streams that are duplicates, before persenting them to the end user. A duplicate is detected by checking if various values on the streams are the same. However, we were not checking for bandwidth. This could lead to a text stream being marked as a duplicate if it had the same language, label, etc as another, even if they did not contain the same text. This changes the utility to also check bandwidth. Closes #3724
We filter out text streams that are duplicates, before persenting them to the end user. A duplicate is detected by checking if various values on the streams are the same. However, we were not checking for bandwidth. This could lead to a text stream being marked as a duplicate if it had the same language, label, etc as another, even if they did not contain the same text. This changes the utility to also check bandwidth. Closes #3724
We filter out text streams that are duplicates, before persenting them to the end user. A duplicate is detected by checking if various values on the streams are the same. However, we were not checking for bandwidth. This could lead to a text stream being marked as a duplicate if it had the same language, label, etc as another, even if they did not contain the same text. This changes the utility to also check bandwidth. Closes #3724
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.3.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master
?Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
I loaded the DASH manifest on Shaka demo app on Chrome.
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
I can reproduce the bug using a Samsung TV (UT4300, Tizen 5.5) and a DASH Playready manifest
What are the manifest and license server URIs?
This is the important part:
I can send you the manifest file via email if needed.
What configuration are you using? What is the output of
player.getConfiguration()
?Base config on Shaka demo app
What did you do?
Load the manifest in Shaka demo app
What did you expect to happen?
Shaka should show 3 choice in the caption menu.
What actually happened?
The manifest contains 3 different subtitles but Shaka show only 2 possible choice: "en", "ger".
Shaka ignore the second "ger" subtitle even if the
representation id
andbandwidth
are different.The text was updated successfully, but these errors were encountered: