Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate audio and video MIME types to Track API #3888

Closed
joeyparrish opened this issue Jan 20, 2022 · 2 comments · Fixed by #3892 or #4009
Closed

Add separate audio and video MIME types to Track API #3888

joeyparrish opened this issue Jan 20, 2022 · 2 comments · Fixed by #3892 or #4009
Assignees
@avelad
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.0

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

CAF would like to be able to determine the audio and video MIME types separately, and without resorting to the Manifest API.

Describe the solution you'd like

Add videoMimeType and audioMimeType fields to shaka.extern.Track.

Describe alternatives you've considered

This is already available from shaka.extern.Stream within shaka.extern.Manifest, but getManifest() is discouraged.

Additional context

b/114766347 for internal context
@joeyparrish joeyparrish added type: enhancement New feature or request flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this flag: good first issue This might be a relatively easy issue; good for new contributors priority: P2 Smaller impact or easy workaround labels Jan 20, 2022
@shaka-bot shaka-bot added this to the Backlog milestone Jan 20, 2022
@avelad
Copy link
Member

avelad commented Jan 20, 2022

@joeyparrish I can work on this tomorrow, if you're interested...

@avelad avelad mentioned this issue Jan 21, 2022
Merged
@joeyparrish
Copy link
Member Author

Thanks!

joeyparrish pushed a commit that referenced this issue Jan 24, 2022
feat: Add separate audio and video MIME types to Track API (#3892)
74c491d 
Fixes: #3888
@github-actions github-actions bot mentioned this issue Feb 12, 2022
Closed
@github-actions github-actions bot mentioned this issue Mar 3, 2022
Merged
@github-actions github-actions bot mentioned this issue Mar 22, 2022
Closed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
@avelad avelad modified the milestones: Backlog, v4.0 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@avelad avelad

Labels
flag: good first issue This might be a relatively easy issue; good for new contributors flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.0
3 participants
@joeyparrish @avelad @shaka-bot