-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FairPLay is not working after PatchedMediaKeysApple polyfill is removed #4001
Comments
No, it's not expected. That was recently changed, but the change hasn't made it into a release yet. What you see on appspot is the most recent release. @pedjoni8, what version of Safari are you using? What version of macOS / iOS? @valotvince, I believe that was a change you made, correct? Any advice? Can you help debug? |
macOS 12.1 |
I've accidentally closed issue, sorry about that. |
👋 I've taken a quick look to the code, and the license errors with:
@pedjoni8 Does your fairplay token sent in Something I didn't anticipated in my PR is the need of the contentId through skd initDataType. It could be retrieved but is not accessible from outside Shaka lib right now.
We could set a new parameter on the license request |
pallycon sends content id through modified initData. They are using this callback: In case when PatchedMediaKeysApple polyfill is not used, callback is not called (because This is something I see from debugging, have in mind I'm not not that good in this DRM stuff as you are :) |
@pedjoni8 Yep since latest Safari, we can use the standard EME API to setup & request a license, rather than the Apple MediaKeys. In that case, the Pallycon should already support that way since they already support Widevine, PlayReady through modern EME APIs, we just have to find out how it works 😅 (maybe talk to them through customer support ?) |
@valotvince I can try, I'm not subscribed on their platform, but I can open issue on their GitHub :) |
Adds drmInfo field to all LICENSE-type requests. Based on comments here: #4001 (comment)
Hi everyone, Please see if the changes in #4030 resolve this for you. Thanks! |
If I understand this correctly, idea here is to use requestFIlter to change spc message (add content id) that is being sent to licence server? Previously, initData was changed before calling session.generateRequest(). To be honest, I don't know if this can work and I also don't know how to add contend id to spc message using requestFIlter. |
The change done in #4030 allows you to get the keyId (and/or contentId, assetId) for your content and give it back to the license server through the request (if the license server supports it) or directly through the license token that Pallycon seems to use to enforce policies. Did you had time to write an issue to them ? :) |
The main problem is that it works when using MSE, but not when we use src=, I'm working in another solution. |
i didn't write an isssue to them, sorry, didn't have the time. |
Adds initData and initDataType field to all LICENSE-type requests. Based on comments here: #4001 (comment)
@pedjoni8 , Could you write to them? Is there anything else we can do? |
We switched to another DRM service. I'm closing this issue. |
Hi, I'm in the process of developing html5 player with DRM support.
While I was going through some working examples, I've noticed that Pallycon sample with Shaka player does not work since PatchedMediaKeysApple polyfill is removed for newer Safari versions.
const safariVersion = shaka.util.Platform.safariVersion();
if (navigator.requestMediaKeySystemAccess &&
// eslint-disable-next-line no-restricted-syntax
MediaKeySystemAccess.prototype.getConfiguration &&
safariVersion && safariVersion >= 14) {
// Unprefixed EME is preferable.
return;
}
When I used one of the hosted builds (for example), FPS is working, because PatchedMediaKeysApple polyfill code part is commented, but when I've used github code with latest commit, FPS is not wokring.
Is this behavior expected?
The text was updated successfully, but these errors were encountered: