Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Downgrade less #3982

Merged
merged 1 commit into from
Feb 22, 2022
Merged

build: Downgrade less #3982

merged 1 commit into from
Feb 22, 2022

Conversation

joeyparrish
Copy link
Member

Downgrade less to v3. v4 is failing on macOS for some reason. See
less/less.js#3693

This also makes some less/CSS changes that are useful for future
upgrades:

  • wrap all calculations in calc(), which is required in less v4
  • remove unneeded @transparent variable

Finally, this fixes an erroneous error message that said "extern
generation failed" instead of "CSS compilation failed".

Closes #3981

@joeyparrish
build: Downgrade less
28340a0 
Downgrade less to v3.  v4 is failing on macOS for some reason.  See
less/less.js#3693

This also makes some less/CSS changes that are useful for future
upgrades:

 - wrap all calculations in calc(), which is required in less v4
 - remove unneeded @transparent variable

Finally, this fixes an erroneous error message that said "extern
generation failed" instead of "CSS compilation failed".

Closes #3981
@joeyparrish joeyparrish added type: CI An issue with our continuous integration tests component: build system The issue involves the build system of Shaka Player labels Feb 19, 2022
@joeyparrish joeyparrish merged commit a67cb6e into shaka-project:master Feb 22, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: build system The issue involves the build system of Shaka Player status: archived Archived and locked; will not be updated type: CI An issue with our continuous integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Less compilation failing on macOS
2 participants
@joeyparrish @theodab