Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CEA): Fix multi byte language support in CEA-708 #7837

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(CEA): Fix multi byte language support in CEA-708 #7837

merged 1 commit into from
Jan 7, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 7, 2025

Fixes #7829

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Jan 7, 2025
@avelad avelad added this to the v4.13 milestone Jan 7, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 78.95%

@avelad avelad merged commit 5b13332 into shaka-project:main Jan 7, 2025
23 checks passed
@avelad avelad deleted the multibyte-cea-708 branch January 7, 2025 12:24
@shaka-bot shaka-bot mentioned this pull request Jan 7, 2025
Merged
avelad added a commit that referenced this pull request Jan 10, 2025
@avelad
fix(CEA): Fix multi byte language support in CEA-708 (#7837)
12f2e2b 
Fixes #7829
@shaka-bot shaka-bot mentioned this pull request Jan 10, 2025
Merged
avelad added a commit that referenced this pull request Jan 10, 2025
@avelad
fix(CEA): Fix multi byte language support in CEA-708 (#7837)
4f18e72 
Fixes #7829
@shaka-bot shaka-bot mentioned this pull request Jan 10, 2025
Merged
joeyparrish pushed a commit that referenced this pull request Jan 10, 2025
@avelad @joeyparrish
fix(CEA): Fix multi byte language support in CEA-708 (#7837)
61a2875 
Fixes #7829
@shaka-bot shaka-bot mentioned this pull request Jan 10, 2025
Merged
@mtoczko
Copy link

mtoczko commented Jan 16, 2025

Hi @avelad
I performed a test for the Polish language. The word 'źółć' corresponds to

0x18 0x01 0x7c 0xF3 0x18 0x01 0x42 0x18 0x01 0x07

The isTextBlock function does not work correctly here.

@danrossi danrossi mentioned this pull request Jan 20, 2025
Open
@avelad
Copy link
Member Author

avelad commented Jan 22, 2025

Hi @avelad I performed a test for the Polish language. The word 'źółć' corresponds to

0x18 0x01 0x7c 0xF3 0x18 0x01 0x42 0x18 0x01 0x07

The isTextBlock function does not work correctly here.

@mtoczko can you open a new issue with a sample stream? Thanks!

@mtoczko mtoczko mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Support P16 codes in C0 CEA708 commands for multi byte language support.
4 participants
@avelad @shaka-bot @mtoczko @theodab