Skip to content

Commit

Permalink
fix: Fix msedgedriver version detection (#20)
Browse files Browse the repository at this point in the history
The version string for msedgedriver has been updated, and our parser
needs updating, too. Otherwise, we reinstall msedgedriver every time,
even if we don't need to.
  • Loading branch information
joeyparrish authored Dec 14, 2022
1 parent a86ff59 commit 3838b88
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions edge.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ class EdgeWebDriverInstaller extends WebDriverInstallerBase {

const output = await InstallerUtils.getCommandOutputOrNullIfMissing(
[outputPath, '--version']);
// Output is a string like "MSEdgeDriver 96.0.1054.62 (sha1)\n"
return output ? output.trim().split(' ')[1] : null;
// Output is a string like "Microsoft Edge WebDriver 108.0.1462.46 ...\n"
return output ? output.trim().split(' ')[3] : null;
}

/**
Expand Down

0 comments on commit 3838b88

Please sign in to comment.