Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert EdgeDriver 115+ workaround #35

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: Revert EdgeDriver 115+ workaround #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions edge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,7 @@ class EdgeWebDriverInstaller extends WebDriverInstallerBase {
return `${CDN_URL}/LATEST_RELEASE_${majorVersion}_${platform}`;
};

let idealMajorVersion = parseInt(browserVersion.split('.')[0], 10);

// Work around https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102,
// in which Linux versions of msedgedriver launch Chrome instead of Edge
// starting with version 115. For now, driver version 114 is working for
// Edge 115 on Linux.
if (os.platform() == 'linux') {
if (idealMajorVersion > 114) {
idealMajorVersion = 114;
}
}
const idealMajorVersion = parseInt(browserVersion.split('.')[0], 10);

return await InstallerUtils.fetchVersionUrlWithAutomaticDowngrade(
idealMajorVersion,
Expand Down