You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think we should modify this variable. And this change only affects the specs, so we're not really testing anything. If anyone were to call the CLI from a file with a different name, they'd get the file name:
So I'd rather revert this and maybe figure out a way to fix it everywhere in a separate PR. Someone opened an issue about it on Thor a while ago, but it hasn't been touched: rails/thor#742
Maybe we could override basename from Thor to ensure it's always equal to package_name?
Looks like it actually comes from Ruby: https://stackoverflow.com/questions/37101151/what-does-file-program-name-mean-in-ruby
I don't think we should modify this variable. And this change only affects the specs, so we're not really testing anything. If anyone were to call the CLI from a file with a different name, they'd get the file name:
So I'd rather revert this and maybe figure out a way to fix it everywhere in a separate PR. Someone opened an issue about it on Thor a while ago, but it hasn't been touched: rails/thor#742
Maybe we could override
basename
from Thor to ensure it's always equal topackage_name
?Originally posted by @rafaelgomesxyz in #221 (comment)
The text was updated successfully, but these errors were encountered: