Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix localhost location #409

Closed
wants to merge 1 commit into from

Conversation

tjnet
Copy link

@tjnet tjnet commented Jul 16, 2017

fix localhost location of README.

Please see #404 😃


This change is Reviewable

@justin808
Copy link
Member

@tjnet this line should be configuring port 3000:

port ENV.fetch("PORT") { 3000 }

Are you sure you don't have PORT defined in your environment to be 5000?

FWIW, I also define PORT in my environment to be 3000.

The default port for foreman to use with Rails is 5000.

@tjnet
Copy link
Author

tjnet commented Jul 17, 2017

Are you sure you don't have PORT defined in your environment to be 5000?

No, I don't have.

FWIW, I also define PORT in my environment to be 3000.

oh... I think that newbie can not notice this .
It might be good idea to write this in README 😈

@justin808
Copy link
Member

I'm not clear why you're getting port 5000 when we configure the port to be 3000 in the puma file.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@tjnet
Copy link
Author

tjnet commented Jul 19, 2017

FWIW, I also define PORT in my environment to be 3000.

I couldn't notice this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants