-
Notifications
You must be signed in to change notification settings - Fork 380
Lock RuboCop extension gem versions to prevent CI failures #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Lock rubocop-performance to 1.23.1 (was ~> 1.13) - Lock rubocop-rails to 2.29.1 (was no version constraint) - Lock rubocop-rspec to 3.4.0 (was ~> 3.3) This prevents future CI failures due to new RuboCop versions introducing stricter rules. When we want to upgrade RuboCop rules, we can do so intentionally in a separate PR with proper code fixes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Warning Rate limit exceeded@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
Auto-fix 24 RuboCop offenses detected by the locked versions: - Update redundant .all method calls - Modernize strong parameters syntax - Improve Rails path methods - Update where clause usage - Use Rails.env.local? method This ensures the locked RuboCop versions pass CI while maintaining current code quality standards. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Review app for PR #653 was successfully deleted |
* Lock RuboCop extension gem versions to prevent CI failures - Lock rubocop-performance to 1.23.1 (was ~> 1.13) - Lock rubocop-rails to 2.29.1 (was no version constraint) - Lock rubocop-rspec to 3.4.0 (was ~> 3.3) This prevents future CI failures due to new RuboCop versions introducing stricter rules. When we want to upgrade RuboCop rules, we can do so intentionally in a separate PR with proper code fixes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix all RuboCop violations with locked versions Auto-fix 24 RuboCop offenses detected by the locked versions: - Update redundant .all method calls - Modernize strong parameters syntax - Improve Rails path methods - Update where clause usage - Use Rails.env.local? method This ensures the locked RuboCop versions pass CI while maintaining current code quality standards. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Summary
Lock RuboCop extension gem versions to prevent future CI failures caused by automatic updates to newer versions with stricter rules.
Changes
1.23.1
(was~> 1.13
)2.29.1
(was no version constraint)3.4.0
(was~> 3.3
)Why This Change?
RuboCop extensions were not properly version-locked, causing CI to fail when new versions introduced stricter linting rules. This change ensures consistent CI behavior while allowing intentional RuboCop upgrades in separate PRs.
Benefits
Next Steps
After merging this PR, RuboCop rule violations can be fixed in subsequent PRs with full control over when and how to address them.
🤖 Generated with Claude Code
This change is