Skip to content

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Sep 21, 2025

Summary

Lock RuboCop extension gem versions to prevent future CI failures caused by automatic updates to newer versions with stricter rules.

Changes

  • rubocop-performance: Lock to 1.23.1 (was ~> 1.13)
  • rubocop-rails: Lock to 2.29.1 (was no version constraint)
  • rubocop-rspec: Lock to 3.4.0 (was ~> 3.3)

Why This Change?

RuboCop extensions were not properly version-locked, causing CI to fail when new versions introduced stricter linting rules. This change ensures consistent CI behavior while allowing intentional RuboCop upgrades in separate PRs.

Benefits

  • ✅ Stable CI builds
  • ✅ Predictable linting behavior
  • ✅ Controlled RuboCop rule updates

Next Steps

After merging this PR, RuboCop rule violations can be fixed in subsequent PRs with full control over when and how to address them.

🤖 Generated with Claude Code


This change is Reviewable

- Lock rubocop-performance to 1.23.1 (was ~> 1.13)
- Lock rubocop-rails to 2.29.1 (was no version constraint)
- Lock rubocop-rspec to 3.4.0 (was ~> 3.3)

This prevents future CI failures due to new RuboCop versions introducing
stricter rules. When we want to upgrade RuboCop rules, we can do so
intentionally in a separate PR with proper code fixes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

coderabbitai bot commented Sep 21, 2025

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b57a728 and 4821d71.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • Gemfile (1 hunks)
  • app/controllers/comments_controller.rb (2 hunks)
  • app/controllers/pages_controller.rb (1 hunks)
  • lib/tasks/ci.rake (1 hunks)
  • lib/tasks/daily.rake (1 hunks)
  • spec/rails_helper.rb (1 hunks)
  • spec/rescript/rescript_spec.rb (1 hunks)
  • spec/stimulus/turbo_spec.rb (1 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lock-rubocop-versions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:

/deploy-review-app

Deploy your PR branch for testing

/delete-review-app

Remove the review app when done

/help

Show detailed instructions, environment setup, and configuration options.


Auto-fix 24 RuboCop offenses detected by the locked versions:
- Update redundant .all method calls
- Modernize strong parameters syntax
- Improve Rails path methods
- Update where clause usage
- Use Rails.env.local? method

This ensures the locked RuboCop versions pass CI while maintaining
current code quality standards.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@justin808 justin808 mentioned this pull request Sep 21, 2025
6 tasks
@justin808 justin808 merged commit 6e5113f into master Sep 21, 2025
8 checks passed
@justin808 justin808 deleted the lock-rubocop-versions branch September 21, 2025 07:27
Copy link

github-actions bot commented Sep 21, 2025

✅ Review app for PR #653 was successfully deleted

View Completed Delete Logs

Control Plane Organization

justin808 added a commit that referenced this pull request Sep 28, 2025
* Lock RuboCop extension gem versions to prevent CI failures

- Lock rubocop-performance to 1.23.1 (was ~> 1.13)
- Lock rubocop-rails to 2.29.1 (was no version constraint)
- Lock rubocop-rspec to 3.4.0 (was ~> 3.3)

This prevents future CI failures due to new RuboCop versions introducing
stricter rules. When we want to upgrade RuboCop rules, we can do so
intentionally in a separate PR with proper code fixes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix all RuboCop violations with locked versions

Auto-fix 24 RuboCop offenses detected by the locked versions:
- Update redundant .all method calls
- Modernize strong parameters syntax
- Improve Rails path methods
- Update where clause usage
- Use Rails.env.local? method

This ensures the locked RuboCop versions pass CI while maintaining
current code quality standards.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant