fix: Always run final install to prevent edge cases

Address CodeRabbit suggestion #1:
- Remove conditional logic that could skip final install
- Always run install_js_dependencies to ensure packages are properly installed
- Update test to reflect the improved behavior
- Prevents scenarios where no install runs when package_json methods fail

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: ihabadham

lib/generators/react_on_rails/js_dependency_manager.rb

@@ -54,8 +54,7 @@ def setup_js_dependencies
         @added_dependencies_to_package_json ||= false
         @ran_direct_installs ||= false
         add_js_dependencies
-        # Only run final install if package_json gem was used and no direct installs ran
-        install_js_dependencies if @added_dependencies_to_package_json && !@ran_direct_installs
+        install_js_dependencies
       end
 
       def add_js_dependencies
@@ -76,17 +75,15 @@ def add_react_on_rails_package
                                "react-on-rails"
                              end
 
-        packages_array = [react_on_rails_pkg]
-
         puts "Installing React on Rails package..."
-        if add_js_dependencies_batch(packages_array)
+        if add_js_dependency(react_on_rails_pkg)
           @added_dependencies_to_package_json = true
         else
           # Fallback to direct npm install
           puts "Using direct npm commands as fallback"
-          success = system("npm", "install", *packages_array)
+          success = system("npm", "install", react_on_rails_pkg)
           @ran_direct_installs = true if success
-          handle_npm_failure("react-on-rails package", packages_array) unless success
+          handle_npm_failure("react-on-rails package", [react_on_rails_pkg]) unless success
         end
       end
 

spec/react_on_rails/generators/message_deduplication_spec.rb

@@ -118,10 +118,10 @@
                                                        "package.json")).and_return(true)
       end
 
-      it "does not run the bulk install after direct installs" do
-        # Expect individual package installs but no bulk install
+      it "runs individual installs plus final install" do
+        # Expect individual package installs plus one final bulk install
         expect(install_generator).to receive(:system).with("npm", "install", anything).at_least(:once).and_return(true)
-        expect(install_generator).not_to receive(:system).with("npm", "install")
+        expect(install_generator).to receive(:system).with("npm", "install").once.and_return(true)
 
         # Run the dependency setup
         install_generator.send(:setup_js_dependencies)