Skip to content

Commit

Permalink
cleaned up rubocop warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
eacaps committed Jul 21, 2016
1 parent d99fc36 commit 6fdb73a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions app/helpers/react_on_rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ def initialize_redux_stores

# This is the definitive list of the default values used for the rails_context, which is the
# second parameter passed to both component and store generator functions.
# rubocop:disable Metrics/AbcSize
def rails_context(server_side:)
@rails_context ||= begin
result = {}
Expand Down
6 changes: 3 additions & 3 deletions spec/dummy/app/mailers/dummy_mailer.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
class DummyMailer < ActionMailer::Base
add_template_helper(ReactOnRailsHelper)
default from: 'nobody@nope.com'
default from: "nobody@nope.com"
# layout 'mailer'

def hello_email
mail(to: 'otherperson@nope.com', subject: "you've got mail")
mail(to: "otherperson@nope.com", subject: "you've got mail")
end
end
end
1 change: 1 addition & 0 deletions spec/dummy/config/initializers/react_on_rails.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ def self.custom_context(view_context)
somethingUseful: view_context.session[:something_useful]
}
rescue
result = {}
end
result
end
Expand Down
6 changes: 3 additions & 3 deletions spec/dummy/spec/requests/server_render_check_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@
end

describe "server render mailer" do
it 'sends email okay' do
it "sends email okay" do
mail = DummyMailer.hello_email
expect(mail.subject).to match 'mail'
expect(mail.body).to match 'Mr. Mailing Server Side Rendering'
expect(mail.subject).to match "mail"
expect(mail.body).to match "Mr. Mailing Server Side Rendering"
end
end

Expand Down

0 comments on commit 6fdb73a

Please sign in to comment.