resolved some reviewed suggestions

shakacode · Jul 22, 2016 · 840bc62 · 840bc62
1 parent 9b958fb
commit 840bc62
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/app/helpers/react_on_rails_helper.rb b/app/helpers/react_on_rails_helper.rb
@@ -345,7 +345,7 @@ def initialize_redux_stores
  def rails_context(server_side:)
  @rails_context ||= begin
  result = {}
- unless request.nil?
+ if request.present?
  # Using Addressable instead of standard URI to better deal with
  # non-ASCII characters (see https://github.com/shakacode/react_on_rails/pull/405)
  uri = Addressable::URI.parse(request.original_url)

diff --git a/spec/dummy/app/mailers/dummy_mailer.rb b/spec/dummy/app/mailers/dummy_mailer.rb
@@ -1,7 +1,6 @@
 class DummyMailer < ActionMailer::Base
  add_template_helper(ReactOnRailsHelper)
  default from: "nobody@nope.com"
- # layout 'mailer'
 
  def hello_email
  mail(to: "otherperson@nope.com", subject: "you've got mail")

diff --git a/spec/dummy/app/views/dummy_mailer/hello_email.html.erb b/spec/dummy/app/views/dummy_mailer/hello_email.html.erb
@@ -4,4 +4,4 @@ Someone emailed this to you:
  helloWorldData: {
  name: "Mr. Mailing Server Side Rendering"
  }
-}, prerender: true) %>
+}, prerender: true) %>