Skip to content

Commit

Permalink
Fixed devBuild for webpackConfigLoader.js (#877)
Browse files Browse the repository at this point in the history
Fixed incorrect value of devBuild for webpackConfigLoader.js
  • Loading branch information
chenqingspring authored and justin808 committed Jul 1, 2017
1 parent 082e5d1 commit 9d8a987
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Changes since last non-beta release.

*Please add entries here for your pull requests.*

## [8.0.4]
### Fixed
- Fixed `devBuild` for webpack production build. [#877](https://github.com/shakacode/react_on_rails/pull/877) by [chenqingspring](https://github.com/chenqingspring)

## [8.0.3]
### Fixed
- Ruby 2.1 issue due to `<<~` as reported in [issue #870](https://github.com/shakacode/react_on_rails/issues/870). [#867](https://github.com/shakacode/react_on_rails/pull/867) by [justin808](https://github.com/justin808)
Expand Down Expand Up @@ -611,7 +615,8 @@ Best done with Object destructing:
##### Fixed
- Fix several generator related issues.
[Unreleased]: https://github.com/shakacode/react_on_rails/compare/8.0.3...master
[Unreleased]: https://github.com/shakacode/react_on_rails/compare/8.0.4...master
[8.0.4]: https://github.com/shakacode/react_on_rails/compare/8.0.3...8.0.4
[8.0.3]: https://github.com/shakacode/react_on_rails/compare/8.0.2...8.0.3
[8.0.2]: https://github.com/shakacode/react_on_rails/compare/8.0.1...8.0.2
[8.0.1]: https://github.com/shakacode/react_on_rails/compare/8.0.0...8.0.1
Expand Down
3 changes: 1 addition & 2 deletions webpackConfigLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ const configLoader = (configPath) => {
const configEnv = (process.env.NODE_ENV || process.env.RAILS_ENV || 'development');
const ymlConfigPath = join(configPath, 'webpacker_lite.yml');
const configuration = safeLoad(readFileSync(ymlConfigPath, 'utf8'))[configEnv];

const devBuild = env !== 'production';
const devBuild = configEnv !== 'production';
const hotReloadingHost = configuration.hot_reloading_host || DEFAULT_HOT_RELOADING_HOST;

// NOTE: Rails path is hard coded to `/public`
Expand Down

0 comments on commit 9d8a987

Please sign in to comment.