Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions tell users to start rails with rails s #1488

Closed
justin808 opened this issue Sep 26, 2022 Discussed in #1485 · 4 comments
Closed

Instructions tell users to start rails with rails s #1488

justin808 opened this issue Sep 26, 2022 Discussed in #1485 · 4 comments

Comments

@justin808
Copy link
Member

Discussed in #1485

Originally posted by jasonfb September 23, 2022
Please note I am stuck getting the basic installation working so perhaps there is a gap in my understanding. please elucidate me if so.
see #1483 for my issue where I am stuck here.

however, I tried both foreman start -f Procfile.dev-static and also rails s and both produce the same results (see issue)

What I don't understand is if the webpack dev server is needed to be running in the background to make it work when compile is set to false (which the react_on_rails installer has just done in the prior step), why do these instructions tell the user to start the server with rails s and not foreman start -f Procfile.dev-static

Getting Started | Shakacode 2022-09-23 08-54-27

@justin808
Copy link
Member Author

#1488

FYI -- if webpacker.yml setting for compile is true, then the current instructions are correct. However, that's not the recommended path, which is to either the webpack-dev-server via bin/webpacker-dev-server or run bin/webpacker --watch. These are setup by the Procfile examples.

@mgmodell
Copy link
Contributor

Without specifying any sort of starting point, these instructions do not work. I ran a rails new using the latest rails (7.0.4) and the defaults there do not include anything webpacker. Therefore, whether I launch with rails s, foreman or I specify that compile is true, it does not function.

I'll update the docs to specify the prerequisite of a rails app with webpacker enabled (i.e. rails n _____ --javascript=webpack) because we've already got instructions for adding it if it isn't already present.

mgmodell added a commit to mgmodell/react_on_rails that referenced this issue Nov 30, 2022
justin808 pushed a commit that referenced this issue Dec 1, 2022
@justin808
Copy link
Member Author

@mgmodell OK to close?

@mgmodell
Copy link
Contributor

mgmodell commented Dec 1, 2022

Certainly looks like it to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants