New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node version #632

Closed

dijonkitchen opened this issue Dec 1, 2016 · 3 comments

Labels

Contributor

dijonkitchen commented Dec 1, 2016 •

edited

Loading

Should this generated package.json be update for at least the latest LTS Node version 6.9.1? https://github.com/shakacode/react_on_rails/blob/master/lib/generators/react_on_rails/templates/base/base/package.json.tt

Looks like the tutorial was updated to the latest Stable at 7.2.0: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/package.json#L7

https://nodejs.org/en/

Member

justin808 commented Dec 2, 2016

Yes, it should be updated!

Member

justin808 commented Dec 2, 2016

I'd say 7.2

justin808 added the enhancement label

Member

justin808 commented Feb 2, 2017

@dijonkitchen A PR would be great. Maybe consider helping us with #622?

justin808 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment