Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yarn and Webpack v2 for default generators #622

Closed
wants to merge 1 commit into from

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Nov 25, 2016

Now that webpack v2 is out, let's update to yarn and Webpack v2.

Any volunteers to help us finish up this one?

@marcusmolchany? @squadette?

This change is Reviewable

@justin808
Copy link
Member Author

@robwise Please review.

@justin808
Copy link
Member Author

This is blocked by this issue: yarnpkg/yarn#1498

Once this is done, we can continue with yarn.

😢

@marcusmolchany
Copy link
Contributor

looks like bestander replied and said 0.18.0 fixed this issue. need any help with this PR?

@justin808
Copy link
Member Author

@marcusmolchany I'd be thrilled if you'd take this one on. You can create a fork and create a branch off my branch here!

@justin808
Copy link
Member Author

@marcusmolchany let me know if you can get this done this week.

@marcusmolchany
Copy link
Contributor

hey @justin808 i copied down your branch and rebased to origin/master but had a few failing tests. i'm on vacation after today so i don't think i can take another stab at it until next week.

@justin808
Copy link
Member Author

@marcusmolchany Any word on this one?

@marcusmolchany
Copy link
Contributor

hey @justin808 looking at this again today, i'll keep you posted!

@squadette
Copy link
Contributor

I did some updating and rebasing on https://github.com/squadette/react_on_rails/commits/use-yarn branch.

#646 is also there.

I'll submit PR when ready.

Thanks,

@justin808
Copy link
Member Author

@squadette Any update? I'd like to get this one ASAP.

@marcusmolchany
Copy link
Contributor

@squadette @justin808 i haven't had time to update my branch so going to stop working on this if you are making progress

@squadette
Copy link
Contributor

squadette commented Jan 9, 2017

Well, few more commits later it passes the test suite. I'm going to rebase commits in a logical order and submit PR.

But, suddenly, rubocop decided to run and find 300+ trivial "offences", I wonder if that's really necessary.

@justin808
Copy link
Member Author

@squadette Did you submit a PR?

@justin808 justin808 changed the title Switch to yarn Switch to yarn and Webpack v2 for default generators Feb 2, 2017
@justin808 justin808 added this to the 6.6 milestone Feb 2, 2017
@justin808 justin808 mentioned this pull request Feb 2, 2017
@squadette
Copy link
Contributor

This is my current branch: https://github.com/squadette/react_on_rails/commits/yarn-for-upstream

but it's failing in Travis, because of some issue with Yarn which looks like bug in Yarn. however, this is extremely suspicious, because it's the first time I see bugs in Yarn!

Here is the travis build: https://travis-ci.org/squadette/react_on_rails/builds/195203670

If anybody can fix that (maybe it's possible by downgrading Yarn back to 0.18.1) — feel free to use that branch.

I'm going to continue working on that again later.

@justin808
Copy link
Member Author

@squadette Thanks for working on this...You might want to

  1. Run basic generator, commit and push to github repo
  2. Make changes needed for yarn and Webpack v2 in a PR and I'll review.
  3. Once we agree on the changes, then we can update the generators.

Yarn and Webpack v2 are ready!

@squadette
Copy link
Contributor

Please see #715

@justin808
Copy link
Member Author

See #715. version 6.6.0!

@justin808 justin808 closed this Feb 18, 2017
@justin808 justin808 deleted the switch-to-yarn branch February 18, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants