Report error in parsing version number #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@squadette, looks good. Can you please add a CHANGELOG entry and I'll merge. |
2 similar comments
|
@squadette, looks good. Can you please add a CHANGELOG entry and I'll merge. |
|
@squadette, looks good. Can you please add a CHANGELOG entry and I'll merge. |
squadette
force-pushed
the
fix-version-parser
branch
from
8698c96
to
a72813a
Compare
squadette
force-pushed
the
fix-version-parser
branch
from
a72813a
to
d5414f6
Compare
|
Fixed, sorry for the delay! |
|
@justin808, please fix tiny copy-paste error in CHANGELOG :) You got link to my account right but the username is copy-pasted. |
|
can you give me a new PR and I'll fix it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you accidentally put "react-on-rails": "9.0.x" in your
package.json, you will get a stack trace.This commit helps you during upgrade and reports error in a readable way.
Closes #489.
This change is