Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc updates, fix test helper #1093

Closed
wants to merge 6 commits into from
Closed

Doc updates, fix test helper #1093

wants to merge 6 commits into from

Commits on Jun 14, 2018

  1. Fixed test helper that rebuilds assets 

    This is the case that is fixed:

Test helper for detecting stale bundles did not properly handle the case
of a server-bundle.js without a hash.

This is reproducible:

git clone https://github.com/shakacode/react-webpack-rails-tutorial
bundle && yarn
rspec
See that the server-bundle.js is reported as missing.
    @justin808
    justin808 committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    09cc48e View commit details
    Browse the repository at this point in the history

  2. Improve React on Rails Configuration setup

    @justin808
    justin808 committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    3117c79 View commit details
    Browse the repository at this point in the history

  3. fixed tests

    @justin808
    justin808 committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    a7f79de View commit details
    Browse the repository at this point in the history

  4. Test fixes

    @justin808
    justin808 committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    0442971 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2018

  1. test fixes

    @justin808
    justin808 committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    53b9609 View commit details
    Browse the repository at this point in the history

  2. Rubocop fix

    @justin808
    justin808 committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    d85d8c5 View commit details
    Browse the repository at this point in the history